feat(shadowsocks): add more Debug implementations #1656
Merged
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
shadowsocks-debug
branch
2 times, most recently
from
0c1901e
to
726de34
Compare
|
Passes with |
link2xt
force-pushed
the
shadowsocks-debug
branch
from
726de34
to
cf31a30
Compare
Most implementations are derived. I would like to add `missing_debug_implementations` lint, but before deriving more Debug implementations we need to add Debug implementations to types exported from `shadowsocks-crypto`.
link2xt
force-pushed
the
shadowsocks-debug
branch
from
cf31a30
to
65009a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most implementations are derived.
I would like to add
missing_debug_implementationslint,but before deriving more Debug implementations
we need to add Debug implementations to types exported
from
shadowsocks-crypto.Closes #1647