404 error after deleting a link from it's own page

[e2jk]

How to reproduce:

• Go to a link's own page (permalink)
• Delete the link
• You are returned to same page, but this time with a 404 error (as the link doesn't exist anymore)

Suggested fix:
If the url to be returned to is going to be a permalink, redirect instead to the home page.

[e2jk]

The code to be altered is around line 1551 in index.php in the current master

$returnurl = ( isset($_POST['returnurl']) ? $_POST['returnurl'] : '?' );
if ($returnurl=='?') { $returnurl = (isset($_SERVER['HTTP_REFERER']) ? $_SERVER['HTTP_REFERER'] : '?'); }
header('Location: '.$returnurl); // After deleting the link, redirect to the page the user was on.

[pikzen]

The easiest (and most logical) fix would be redirecting to / once the link has been deleted.

However, the current case handles passing around a redirect url to a ?do= page. Aside from being almost never used (Deleting a link from another page on another website ?), HTTP_REFERER is set differently on each browser and is almost always set to the previous page.
Opinions on removing all this referer parsing nonsense and just ALWAYS returning to / ?

[e2jk]

I think it is OK to just redirect to Shaarli's home page.
This would only be an issue when you want to delete multiple links from e.g. a search, but (1) how often does this use case happen and (2) you could click twice on the back button and you would be back to the page from which you clicked the delete button.

[e2jk]

I've created pull request #90 that redirects to ? (the default when returnurlor HTTP_REFERER were empty). Please review, test and merge.

[nodiscc]

Fixed in #90

[nodiscc]

@e2jk I frequently hit this bug:

This would only be an issue when you want to delete multiple links from e.g. a search, but (1) how often does this use case happen and (2) you could click twice on the back button and you would be back to the page from which you clicked the delete button.

It's very annoying when you are trying to cleanup links with a certain tag. I think if either $searchtags or $searchterm are defined, we should add these params to the next request (so you would be redirected to the previous serach. Hitting back twice is confusing and annoying.

I'll aopen another issue for this.