Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve login management and session operations #1150

Open
virtualtam opened this issue Jun 3, 2018 · 0 comments
Open

Improve login management and session operations #1150

virtualtam opened this issue Jun 3, 2018 · 0 comments
Assignees
Labels
cleanup code cleanup and refactoring enhancement security
Milestone

Comments

@virtualtam
Copy link
Member

Follow-up to #1086

Separation of concerns

  • move the IP ban management to a dedicated class
  • add get() and set() methods to SessionManager to wrap $_SESSION[...] operations
  • add getVisibility() and setVisibility() methods to SessionManager
  • move storeLoginInfo() and logout() logic from SessionManager to LoginManager

Security

Improvements

  • add ConfigManager->isConfigured() to check if the user has setup Shaarli
  • review the session extension mechanism
  • review the stay-signed-in mechanism
@virtualtam virtualtam added this to the 0.10.1 milestone Jun 3, 2018
@virtualtam virtualtam self-assigned this Jun 3, 2018
@ArthurHoaro ArthurHoaro modified the milestones: 0.10.1, 0.10.2 Jul 29, 2018
@ArthurHoaro ArthurHoaro modified the milestones: 0.10.2, 0.10.3 Aug 11, 2018
@virtualtam virtualtam modified the milestones: 0.10.3, 0.11.0 Feb 23, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.0, 0.11.1 Jul 27, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.1, 0.11.2 Aug 7, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.12.0, 0.12.1 Sep 3, 2020
@ArthurHoaro ArthurHoaro modified the milestones: 0.12.1, 0.13.0 Nov 8, 2020
@nodiscc nodiscc modified the milestones: 0.13.0, 0.14.0 Nov 22, 2023
@nodiscc nodiscc added the cleanup code cleanup and refactoring label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup and refactoring enhancement security
Projects
None yet
Development

No branches or pull requests

3 participants