Non-UI templates should not be duplicated

[virtualtam]

The following templates are present in both default and vintage resource directories:

• dailyrss.html
• feed.atom.html
• feed.rss.html
• export.bookmarks.html

As they do not contain any theme-specific content, and are not likely to be overridden by 3rd-party template developers, they should be refactored and/or moved to a separate directory (e.g. common/).

[ArthurHoaro]

It's a good idea but I think it'll be a bit complicated because RainTPL expect one template directory, so we'll have to change it depending on the page we're on. Also, custom themes should still be able to override these common templates.

[virtualtam]

Given these templates are quite simple, we could avoid using RainTPL (or have a dedicated instance for these use cases) and move the rendering part to the respective classes (FeedBuilder, NetscapeBookmarkUtils, etc.), which would also make sense from an OOP point of view.

Is there an actual benefit in allowing to override feeds' and bookmark exports' content?

[ArthurHoaro]

I don't think there is an existing use case, but one could want to have custom things in their RSS feed. Could symlink be an option?

[virtualtam]

Symlinks would be an issue for Windows + Git users, as you need special privileges to create them:

• https://github.com/git-for-windows/git/wiki/Symbolic-Links
• https://stackoverflow.com/questions/5917249/git-symlinks-in-windows

This would also be an issue for repository and release archives.

I'm not sure how many people actually rely on feeds, but I don't think it would be too bold to say that there would be little interest in further customizing feed content (besides through supported plugins such as Markdown).

[ArthurHoaro]

Windows. ◕‿◕✿
But yes, I agree. In any case, modifying feeds content is doable through plugins.