Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can variable ld_prune_index_to_drop be implimented as a boolean array #920

Open
timothymillar opened this issue Sep 30, 2022 · 0 comments
Open

Can variable ld_prune_index_to_drop be implimented as a boolean array #920

timothymillar opened this issue Sep 30, 2022 · 0 comments
Labels
data representation Issues related to how data is represented: data types, data structures, indexes, access methods, etc question Further information is requested

Comments

@timothymillar
Copy link
Collaborator

This variable is currently an array of integer array of dimension "variant_indexes". If it could instead be treated as a boolean array of with dimension "variants" the unique dimension would be avoided. As mentioned in https://github.com/pystatgen/sgkit/pull/913#issuecomment-1261958057 this is performance sensitive code and avoiding a unique dimension would not be worth an efficiency loss.
@timothymillar timothymillar added question Further information is requested data representation Issues related to how data is represented: data types, data structures, indexes, access methods, etc labels Sep 30, 2022
@timothymillar timothymillar mentioned this issue Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data representation Issues related to how data is represented: data types, data structures, indexes, access methods, etc question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timothymillar