Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate persisting input dataset in cluster memory on GWAS performance #449

Closed
tomwhite opened this issue Jan 28, 2021 · 1 comment
Closed

Comments

@tomwhite
Copy link
Collaborator

In #390 it might help performance to persist the dosage data in cluster memory, and avoid loading it from Zarr for each phenotype. This could be tested using the benchmark using simulated data.

@tomwhite
Copy link
Collaborator Author

tomwhite commented Feb 1, 2021

I did a quick test for this (notebook), by calling the following before calling the gwas function:

from dask.distributed import wait
XL = XL.persist()
wait(XL)

This has the effect of pinning the biggest matrix in the cluster memory.

The time went from 103s (load from Zarr + gwas) to 66s (gwas only), so since we run a computation for each phenotype on the same input, there are potential savings here of ~30%.

Performance reports:

(BTW I noticed that the actual computation times shown in the task stream were ~75s and ~40s respectively, so the saving may actually be more like 50%. I wonder if the missing time goes to serializing the task graph - if so then hopefully this will be improved by some of the work going on in Dask and Dask Distributed to move to HighLevelGraph. There's some discussion of the problem in dask/distributed#3872. We might also look at increasing chunk sizes to alleviate the problem.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant