Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sfztools/sfizz
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: develop
Choose a base ref
...
head repository: sfztools/sfizz
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: essej-onpolyaft
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 6 files changed
  • 2 contributors

Commits on Oct 15, 2023

  1. allow polyaftertouch extended CC (130) to respect note num, especiall… 

    …y useful when used as trigger with on_lo/hicc130 opcodes, so that the key range can be used select appropriate regions independently.
    @essej @paulfd
    essej authored and paulfd committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    bf5a778 View commit details
    Browse the repository at this point in the history

  2. Add tests for note-aware polyaft 

    - Test triggering with note information
- Test choking
- Fix logic: don't check that the new CC value changed on polyaftertouch
    cc130 messages (hopefully e-drums don't send multiple polyafts for
    the same note like some controllers do for the pedals...)
    @paulfd
    paulfd committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    9259a1d View commit details
    Browse the repository at this point in the history
Loading