-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SQL ending with a semicolon #575
Comments
Hey @theelderbeever, I think this should simple as adding a few well placed query.replace(";","") statements here. Happy to take a look at this when I have a chance. |
@Jordan-M-Young Awesome and greatly appreciated! |
Good afternoon, I have written some code which i think it fixes the problem, I am not sure though if we need to write some extra tests for that because the behavior for the tests should not change. What do you think @theelderbeever |
@aimtsou do you have a branch or something that I can look at? |
https://github.com/aimtsou/connector-x/blob/aimilios_semicolon/connectorx-python/connectorx/__init__.py On a note, I can remove striping to preserve the original content. I need to think of that |
@theelderbeever Just merged this PR Hopefully things are good to go now |
Describe your feature request
Currently, you can't submit queries that terminate with a semicolon. It would be nice to be able to able to include these. Primary reasons being that it is part of the standard already and a lot of syntax highlighters trigger off of the
;
to stop highlighting.The text was updated successfully, but these errors were encountered: