Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SQL ending with a semicolon #575

Closed
theelderbeever opened this issue Mar 5, 2024 · 6 comments
Closed

Support SQL ending with a semicolon #575

theelderbeever opened this issue Mar 5, 2024 · 6 comments

Comments

@theelderbeever
Copy link

Describe your feature request

Currently, you can't submit queries that terminate with a semicolon. It would be nice to be able to able to include these. Primary reasons being that it is part of the standard already and a lot of syntax highlighters trigger off of the ; to stop highlighting.

image
@Jordan-M-Young
Copy link
Contributor

Hey @theelderbeever,

I think this should simple as adding a few well placed query.replace(";","") statements here.

Happy to take a look at this when I have a chance.

@theelderbeever
Copy link
Author

@Jordan-M-Young Awesome and greatly appreciated!

@aimtsou
Copy link
Contributor

aimtsou commented Apr 4, 2024

Good afternoon,

I have written some code which i think it fixes the problem, I am not sure though if we need to write some extra tests for that because the behavior for the tests should not change.

What do you think @theelderbeever

@theelderbeever
Copy link
Author

@aimtsou do you have a branch or something that I can look at?

@aimtsou
Copy link
Contributor

aimtsou commented Apr 4, 2024

@aimtsou do you have a branch or something that I can look at?

https://github.com/aimtsou/connector-x/blob/aimilios_semicolon/connectorx-python/connectorx/__init__.py
Lines 207-212

On a note, I can remove striping to preserve the original content. I need to think of that

@Jordan-M-Young
Copy link
Contributor

@theelderbeever Just merged this PR Hopefully things are good to go now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants