improve RcsValidator

matthiez · matthiez · commit 3356d7d3e4b6 · 2024-12-03T10:49:19.000+01:00
diff --git a/src/Resource/Rcs/RcsValidator.php b/src/Resource/Rcs/RcsValidator.php
@@ -86,7 +86,7 @@ public function text(): void {
 
         $length = strlen($text);
 
-        if (null === $text || !$length) {
+        if (!$length) {
             throw new InvalidRequiredArgumentException(
                 'You cannot send an empty message.');
         }
@@ -96,7 +96,7 @@ public function text(): void {
     public function to(): void {
         $to = $this->params->getTo();
 
-        if (null === $to || '' === $to) {
+        if ('' === $to) {
             throw new InvalidRequiredArgumentException(
                 'You cannot send a message without specifying a recipient.');
         }

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ public function text(): void {`
`86`	`86`
`87`	`87`	`$length = strlen($text);`
`88`	`88`
`89`		`- if (null === $text \|\| !$length) {`
	`89`	`+ if (!$length) {`
`90`	`90`	`throw new InvalidRequiredArgumentException(`
`91`	`91`	`'You cannot send an empty message.');`
`92`	`92`	`}`
`@@ -96,7 +96,7 @@ public function text(): void {`
`96`	`96`	`public function to(): void {`
`97`	`97`	`$to = $this->params->getTo();`
`98`	`98`
`99`		`- if (null === $to \|\| '' === $to) {`
	`99`	`+ if ('' === $to) {`
`100`	`100`	`throw new InvalidRequiredArgumentException(`
`101`	`101`	`'You cannot send a message without specifying a recipient.');`
`102`	`102`	`}`