Creates tests for new network page feature WIP #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
reviewed
May 27, 2025
| @@ -23,5 +23,6 @@ export default defineConfig({ | |||
| reportSlowTests: null, | |||
| fullyParallel: true, // otherwise, tests in the same file are not run in parallel | |||
| globalSetup: './global.setup', // clean leftovers of previous test runs on start, runs only once | |||
| snapshotPathTemplate: screenshotFolder + '/{testName}/{arg}-{platform}{ext}', | |||
| // eslint-disable-next-line prefer-template | |||
| snapshotPathTemplate: screenshotFolder + '/{testName}/{arg}-{platform}{text}', | |||
There was a problem hiding this comment.
why not make this screenshotFolder part of a templated string (with backtick?) I guess ts complains about the testName and others being there, but without the $ sign?
| @@ -1,3 +1,4 @@ | |||
| // eslint-disable-next-line import/no-cycle | |||
There was a problem hiding this comment.
this will need to be addressed, eventually
Comment on lines
+10
to
+14
| export async function recoverFromSeed( | ||
| window: Page, | ||
| recoveryPhrase: string, | ||
| createDisplayName?: boolean, | ||
| ) { |
There was a problem hiding this comment.
is this createDisplayname used anywhere currently? I feel like recoverFromSeed should fail, if the displayName isn't found, and not blindly offer the option to use "Alice" as one. Why was this needed?
| @@ -43,7 +43,7 @@ export async function waitForTestIdWithText( | |||
| const found = await window.waitForSelector(builtSelector, { | |||
| timeout: maxWait, | |||
| }); | |||
| // console.info('found selector', builtSelector); | |||
| console.info('found selector', builtSelector); | |||
| 'open-url-confirm-button', | ||
| ); | ||
| const href = await el.getAttribute('href'); | ||
| console.log('href', href); |
Comment on lines
+42
to
+45
| // TODO Add string in once crowdin has been updated | ||
| // const expectedText = englishStrippedStr('updated') | ||
| // .withArgs({ relative_time: '0m' }) | ||
| // .toString(); |
Comment on lines
+12
to
+17
| /* Waiting for test id to be fixed | ||
| // Links to test are: | ||
| - Learn more Network link | ||
| - Learn more staking link | ||
| - How to create wallet link | ||
| */ |
There was a problem hiding this comment.
where are we about those test ids?
burtonemily
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network pages