Fixed incorrect usage of lazy (#1760)

Author: SessionHero01

app/src/main/java/org/session/libsession/messaging/sending_receiving/ReceivedMessageProcessor.kt

@@ -39,9 +39,9 @@ import org.session.libsession.utilities.UserConfigType
 import org.session.libsession.utilities.recipients.MessageType
 import org.session.libsession.utilities.recipients.Recipient
 import org.session.libsession.utilities.recipients.getType
-import org.session.protos.SessionProtos
 import org.session.libsignal.utilities.AccountId
 import org.session.libsignal.utilities.Log
+import org.session.protos.SessionProtos
 import org.thoughtcrime.securesms.database.BlindMappingRepository
 import org.thoughtcrime.securesms.database.RecipientRepository
 import org.thoughtcrime.securesms.database.Storage
@@ -515,7 +515,7 @@ class ReceivedMessageProcessor @Inject constructor(
 
         var maxOutgoingMessageTimestamp: Long = 0L
 
-        val currentUserEd25519KeyPair: KeyPair by lazy(LazyThreadSafetyMode.NONE) {
+        val currentUserEd25519KeyPair: KeyPair by lazy {
             requireNotNull(storage.getUserED25519KeyPair()) {
                 "No current user ED25519 key pair available"
             }
@@ -524,7 +524,7 @@ class ReceivedMessageProcessor @Inject constructor(
         val currentUserPublicKey: String get() = currentUserId.hexString
 
 
-        val contactConfigTimestamp: Long by lazy(LazyThreadSafetyMode.NONE) {
+        val contactConfigTimestamp: Long by lazy {
             configFactory.getConfigTimestamp(UserConfigType.CONTACTS, currentUserPublicKey)
         }
 

app/src/main/java/org/session/libsession/snode/model/MessageResponses.kt

@@ -34,7 +34,7 @@ data class RetrieveMessageResponse(
         @SerialName("data")
         val dataB64: String? = null,
     ) {
-        val data: ByteArray by lazy(LazyThreadSafetyMode.NONE) {
+        val data: ByteArray by lazy {
             Base64.decode(dataB64, Base64.DEFAULT)
         }
 

app/src/main/java/org/session/libsession/utilities/Address.kt

@@ -8,10 +8,9 @@ import kotlinx.serialization.Serializable
 import org.session.libsession.messaging.open_groups.OpenGroup
 import org.session.libsignal.utilities.AccountId
 import org.session.libsignal.utilities.IdPrefix
+import org.session.libsignal.utilities.Log
 import org.session.libsignal.utilities.Util
 import java.util.LinkedList
-import org.session.libsignal.utilities.Log
-import kotlin.text.startsWith
 
 @Serializable(with = AddressSerializer::class)
 sealed interface Address : Parcelable, Comparable<Address> {
@@ -81,7 +80,7 @@ sealed interface Address : Parcelable, Comparable<Address> {
     }
 
     data class LegacyGroup(val groupPublicKeyHex: String) : Conversable, GroupLike {
-        override val address: String by lazy(LazyThreadSafetyMode.NONE) {
+        override val address: String by lazy {
             GroupUtil.doubleEncodeGroupID(groupPublicKeyHex)
         }
 
@@ -101,7 +100,7 @@ sealed interface Address : Parcelable, Comparable<Address> {
         override val accountId: AccountId
             get() = blindedId.blindedId
 
-        override val address: String by lazy(LazyThreadSafetyMode.NONE) {
+        override val address: String by lazy {
             "${URI_PREFIX}${blindedId.blindedId.hexString}"
                 .toUri()
                 .buildUpon()
@@ -136,7 +135,7 @@ sealed interface Address : Parcelable, Comparable<Address> {
             }
         }
 
-        override val address: String by lazy(LazyThreadSafetyMode.NONE) {
+        override val address: String by lazy {
             "${URI_PREFIX}${Uri.encode(serverUrl)}"
                 .toUri()
                 .buildUpon()

app/src/main/java/org/thoughtcrime/securesms/auth/LoggedInState.kt

@@ -42,23 +42,23 @@ data class LoggedInState(
             }
         }
 
-        private val paddedSeed: ByteArray by lazy(LazyThreadSafetyMode.NONE) {
+        private val paddedSeed: ByteArray by lazy {
             seed.data + ByteArray(16)
         }
 
-        val accountEd25519KeyPair: KeyPair by lazy(LazyThreadSafetyMode.NONE) {
+        val accountEd25519KeyPair: KeyPair by lazy {
             ED25519.generate(paddedSeed)
         }
 
-        val accountX25519KeyPair: KeyPair by lazy(LazyThreadSafetyMode.NONE) {
+        val accountX25519KeyPair: KeyPair by lazy {
             Curve25519.fromED25519(accountEd25519KeyPair)
         }
 
-        val accountId: AccountId by lazy(LazyThreadSafetyMode.NONE) {
+        val accountId: AccountId by lazy {
             AccountId(IdPrefix.STANDARD, accountX25519KeyPair.pubKey.data)
         }
 
-        val proMasterPrivateKey: ByteArray by lazy(LazyThreadSafetyMode.NONE) {
+        val proMasterPrivateKey: ByteArray by lazy {
             ED25519.generateProMasterKey(paddedSeed)
         }