Simplify display list construction in the API #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Nov 24, 2016
| vec![complex], | ||
| Some(mask), | ||
| &mut auxiliary_lists_builder) | ||
| builder.new_clip_region(&bounds, vec![complex], Some(mask)) |
| @@ -47,13 +48,15 @@ impl BuiltDisplayList { | |||
| pub struct DisplayListBuilder { | |||
| pub mode: DisplayListMode, | |||
| pub list: Vec<DisplayItem>, | |||
| pub auxiliary_lists_builder: AuxiliaryListsBuilder, | |||
|
☔ The latest upstream changes (presumably #528) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me when rebased and servo patch is ready |
This makes it a bit less complicated to use the WebRender API and hides some details that might change later. Fixes servo#574.
Bookkeeping for pipeline_id and the current scroll layer id is logic that is shared among all clients. We can just move this into DisplayListBuilder.
|
@glennw I have added a new commit to this PR. Do you mind taking a look at it and reviewing again? The new commit: 5be4382 The Servo PR is waiting on the WebRender version update in order to update the lock files. Thanks! |
mrobinson
changed the title
|
@mrobinson Both the new commit and the servo PR look good to - feel free to merge this when the Servo PR is available. |
|
@bors-servo r=glennw @glennw Thanks for the review! |
|
📌 Commit 35fd4d6 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 28, 2016
Simplify display list construction in the API This makes it a bit less complicated to use the WebRender API and hides some details that might change later. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/592) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
This was referenced Nov 28, 2016
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a bit less complicated to use the WebRender API and hides
some details that might change later.
This change is