Add API for tweaking debug options. #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an uber-nit, but do you think that toggling is really the best API here, as opposed to set on/off? It requires clients to know the state and doesn't allow multiple clients to interact with the system unless they coordinate… |
Used by Servo to tweak whether profiler is currently running.
|
@bors-servo: r+ |
|
📌 Commit 0c238e4 has been approved by |
|
@bors-servo r=pcwalton |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 0c238e4 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 4, 2016
Add API for tweaking debug options. Right now, it's possible to toggle the profiler. In the future this can include options for subpixel AA, shader hot reload etc. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/526) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, it's possible to toggle the profiler. In the future
this can include options for subpixel AA, shader hot reload etc.
This change is