Use texture layers for render target allocations, remove render phases. #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton |
|
@pcwalton btw I tested this on mac mini hardware, since I know we've had troubles with driver stalls around texture / fbo allocs before. It seemed to be working nicely on my mac mini (and also on linux + osmesa). |
pcwalton
reviewed
Oct 25, 2016
| vec2 st1 = vec2(src.screen_origin_task_origin.zw + src.size.xy) / 2048.0; | ||
| vUv = mix(st0, st1, aPosition.xy); | ||
| vec2 texture_size = vec2(textureSize(sCache, 0)); | ||
| vec2 st0 = vec2(src.screen_origin_task_origin.zw) / texture_size; |
There was a problem hiding this comment.
nit: Do you need the vec2() cast here and below?
| vUv0 = mix(st0, st1, aPosition.xy); | ||
| vec2 texture_size = vec2(textureSize(sCache, 0)); | ||
| vec2 st0 = vec2(src0.screen_origin_task_origin.zw) / texture_size; | ||
| vec2 st1 = vec2(src0.screen_origin_task_origin.zw + src0.size_target_index.xy) / texture_size; |
There was a problem hiding this comment.
Same comment about vec2() as above
|
r=me with a couple of nits |
|
☔ The latest upstream changes (presumably #445) made this pull request unmergeable. Please resolve the merge conflicts. |
glennw
force-pushed
the
texture-layers
branch
from
fef4193 to
3751007
Compare
Instead of splitting the scene into multiple phases, use texture layers to allocate slices as needed for each pass of the render frame. These are pooled and only allocated when the frame render target configuration changes. Previously, the code asserted if it was unable to fit the render tasks into a single render target for a single tile. Now, this (pathological) case is handled correctly. This makes the upcoming dynamic primitive cache support a lot simpler to add. It also means that we don't use a ping-pong allocation style, which typically performs badly on mobile / tiled rendering architectures.
glennw
force-pushed
the
texture-layers
branch
from
3751007 to
8928181
Compare
|
@bors-servo: r+ |
|
📌 Commit 8928181 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 26, 2016
Use texture layers for render target allocations, remove render phases. Instead of splitting the scene into multiple phases, use texture layers to allocate slices as needed for each pass of the render frame. These are pooled and only allocated when the frame render target configuration changes. Previously, the code asserted if it was unable to fit the render tasks into a single render target for a single tile. Now, this (pathological) case is handled correctly. This makes the upcoming dynamic primitive cache support a lot simpler to add. It also means that we don't use a ping-pong allocation style, which typically performs badly on mobile / tiled rendering architectures. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/478) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
kvark
reviewed
Oct 26, 2016
| let (internal_format, gl_format) = gl_texture_formats_for_image_format(texture.format); | ||
| let type_ = gl_type_for_texture_format(texture.format); | ||
|
|
||
| gl::tex_image_3d(texture_id.target, |
There was a problem hiding this comment.
This is concerning. I don't see the previous implementation actually reallocating the texture, like this one. Neither does the method name imply that the texture is going to be changed (create_fbo_for_texture_if_necessary).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of splitting the scene into multiple phases, use texture
layers to allocate slices as needed for each pass of the render
frame. These are pooled and only allocated when the frame render
target configuration changes.
Previously, the code asserted if it was unable to fit the render
tasks into a single render target for a single tile. Now, this
(pathological) case is handled correctly.
This makes the upcoming dynamic primitive cache support a lot
simpler to add. It also means that we don't use a ping-pong
allocation style, which typically performs badly on mobile / tiled
rendering architectures.
This change is