Optimizations to filter effects, blend targets, and batching. #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
r? @pcwalton |
Contributor
|
☔ The latest upstream changes (presumably #463) made this pull request unmergeable. Please resolve the merge conflicts. |
* Switch all filter effects to run through the single source blend shader, instead of composite shader. * Each render target uses a single alpha batcher now that the batching algorithm is reasonably efficient. * Change tile size to 256x256. This seems to be a better tradeoff for GPU vs CPU time on all sites I tried. * Switch blend targets to only allocate the used rect, rather than the entire tile size rect. Closes servo#423.
Member
Author
|
@bors-servo r=pcwalton (from irc) |
Contributor
|
📌 Commit e4213ac has been approved by |
Contributor
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Oct 24, 2016
Optimizations to filter effects, blend targets, and batching. * Switch all filter effects to run through the single source blend shader, instead of composite shader. * Each render target uses a single alpha batcher now that the batching algorithm is reasonably efficient. * Change tile size to 256x256. This seems to be a better tradeoff for GPU vs CPU time on all sites I tried. * Switch blend targets to only allocate the used rect, rather than the entire tile size rect. Closes #423. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/461) <!-- Reviewable:end -->
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #423.
This change is