Add benchmarks for Vec to compare to SmallVec #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ Thanks! |
|
📌 Commit 291eb90 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 17, 2018
Add benchmarks for Vec to compare to SmallVec Preliminary results aren't good, although no benches check for cache efficiency (for example `Vec<Vec<T>>` vs `Vec<SmallVec<[T; N]>>`). Here's a comparison. I used `sed` to split the `_vec` benchmarks out and rename them to have the same name, so `cargo benchcmp` can understand them. ``` name vec.bench ns/iter smallvec.bench ns/iter diff ns/iter diff % speedup bench_extend 69 53 -16 -23.19% x 1.30 bench_extend_from_slice 64 52 -12 -18.75% x 1.23 bench_from_slice 34 52 18 52.94% x 0.65 bench_insert 1,228 1,202 -26 -2.12% x 1.02 bench_macro_from_elem 50 66 16 32.00% x 0.76 bench_macro_from_list 33 47 14 42.42% x 0.70 bench_push 359 424 65 18.11% x 0.85 bench_pushpop 251 348 97 38.65% x 0.72 ``` Closes #87 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/95) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
mbrubeck
added a commit
to mbrubeck/rust-smallvec
that referenced
this pull request
Jul 19, 2018
Changes in this release: * Fix possible double-free in `insert_many` when passed an iterator that panics in `next` (servo#103) * Add a new `union` feature (disabled by default) that reduces the size of the SmallVec struct (servo#94) * Improve performance of `extend` and `from_elem` (servo#93) * Improve performance of `drop` (servo#100) * Update dev-dependency on `bincode` (servo#102) * Update to build without `std` on current Rust nightly (servo#104) * Additional benchmarks (servo#95, servo#97).
mbrubeck
added a commit
to mbrubeck/rust-smallvec
that referenced
this pull request
Jul 19, 2018
Changes in this release: * Fix possible double-free in `insert_many` when passed an iterator that panics in `next` (servo#103) * Add a new `union` feature (disabled by default) that reduces the size of the SmallVec struct (servo#94) * Improve performance of `extend` and `from_elem` (servo#93) * Improve performance of `drop` (servo#100) * Update dev-dependency on `bincode` (servo#102) * Update to build without `std` on current Rust nightly (servo#104) * Additional benchmarks (servo#95, servo#97).
Merged
bors-servo
pushed a commit
that referenced
this pull request
Jul 19, 2018
Version 0.6.3 Changes in this release: * Fix possible double-free in `insert_many` when passed an iterator that panics in `next` (#103) * Add a new `union` feature (disabled by default) that reduces the size of the SmallVec struct (#94) * Improve performance of `extend` and `from_elem` (#93) * Improve performance of `drop` (#100) * Update to build without `std` feature on current Rust nightly (#104) * Additional benchmarks (#95, #97) * Update dev-dependency on `bincode` (#102) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/105) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary results aren't good, although no benches check for cache efficiency (for example
Vec<Vec<T>>vsVec<SmallVec<[T; N]>>).Here's a comparison. I used
sedto split the_vecbenchmarks out and rename them to have the same name, socargo benchcmpcan understand them.Closes #87
This change is