Skip to content

Fix doctype serialization. #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2015
Merged

Fix doctype serialization. #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/serialize/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ impl<'wr, Wr: Write> Serializer<'wr, Wr> {
pub fn write_doctype(&mut self, name: &str) -> io::Result<()> {
try!(self.writer.write_all(b"<!DOCTYPE "));
try!(self.writer.write_all(name.as_bytes()));
self.writer.write_all(b"\n")
self.writer.write_all(b">\n")
}

pub fn write_processing_instruction(&mut self, target: &str, data: &str) -> io::Result<()> {
Expand Down
11 changes: 10 additions & 1 deletion tests/serializer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use std::default::Default;
use std::borrow::ToOwned;

use html5ever::driver::ParseOpts;
use html5ever::{parse_fragment, one_input, serialize};
use html5ever::{parse_fragment, parse, one_input, serialize};
use html5ever_dom_sink::rcdom::RcDom;

fn parse_and_serialize(input: String) -> String {
Expand Down Expand Up @@ -97,3 +97,12 @@ test!(attr_ns_1, r#"<svg xmlns="bleh"></svg>"#);
test!(attr_ns_2, r#"<svg xmlns:foo="bleh"></svg>"#);
test!(attr_ns_3, r#"<svg xmlns:xlink="bleh"></svg>"#);
test!(attr_ns_4, r#"<svg xlink:href="bleh"></svg>"#);

#[test]
fn doctype() {
let dom: RcDom = parse(one_input("<!doctype html>".to_owned()), ParseOpts::default());
dom.document.borrow_mut().children.truncate(1); // Remove <html>
let mut result = vec![];
serialize(&mut result, &dom.document, Default::default()).unwrap();
assert_eq!(String::from_utf8(result).unwrap(), "<!DOCTYPE html>\n");
}