Fix CI #723
Merged
Fix CI #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the check-cfg workaround see SSheldon/rust-objc#125. This is the smallest change that will fix CI. Alternatives include switching to the objc-rs fork and switching to objc2, both of which would be more disruptive and require breaking changes.
Using
-Dwarningsin CI is probably not a good idea without pinning a toolchain version, because warnings get added in newer Rust versions all the time, but this PR doesn't change that yet.Semver checks must have been failing when they were enabled. I allowed failures for now until all the versions are bumped (this will be transitioning from bump-at-release to bump-at-first-breaking-change).