[Fix #1317] Setting stack trace to details and filling instance (#1318)

Signed-off-by: fjtirado <ftirados@redhat.com>

Author: fjtirado

impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowError.java

@@ -15,10 +15,13 @@
  */
 package io.serverlessworkflow.impl;
 
+import io.serverlessworkflow.impl.lifecycle.TaskFailedEvent;
+import io.serverlessworkflow.impl.lifecycle.WorkflowFailedEvent;
 import io.serverlessworkflow.types.Errors;
+import java.io.PrintWriter;
+import java.io.StringWriter;
 
-public record WorkflowError(
-    String type, int status, String instance, String title, String details) {
+public record WorkflowError(String type, int status, String instance, String title, String detail) {
 
   public static Builder error(String type, int status) {
     return new Builder(type, status);
@@ -65,6 +68,38 @@ public static Builder timeout() {
     return error(Errors.TIMEOUT.toString(), Errors.TIMEOUT.status());
   }
 
+  public static WorkflowError error(TaskFailedEvent ev) {
+    return error(ev.cause(), ev.taskContext().position());
+  }
+
+  public static WorkflowError error(WorkflowFailedEvent ev) {
+    return error(ev.cause(), null);
+  }
+
+  private static WorkflowError error(Throwable cause, WorkflowPosition position) {
+    return cause instanceof WorkflowException ex
+        ? ex.getWorkflowError()
+        : commonError(cause, position);
+  }
+
+  private static WorkflowError commonError(Throwable cause, WorkflowPosition position) {
+    StringWriter stackTrace = new StringWriter();
+    try (PrintWriter writer = new PrintWriter(stackTrace)) {
+      cause.printStackTrace(writer);
+      return new WorkflowError(
+          cause.getClass().getTypeName(),
+          500,
+          position == null ? null : position.jsonPointer(),
+          cause.getMessage(),
+          stackTrace.toString());
+    }
+  }
+
+  @Deprecated
+  public String details() {
+    return detail;
+  }
+
   public static class Builder {
 
     private final String type;

impl/core/src/main/java/io/serverlessworkflow/impl/executors/TryExecutor.java

@@ -180,7 +180,7 @@ private CompletableFuture<WorkflowModel> handleException(
               taskContext,
               workflow.definition().application().modelFactory().fromAny(error))) {
         if (errorVariable != null) {
-          taskContext.variables().put(errorVariable, error);
+          taskContext.variables().put(errorVariable, WorkflowErrorExpr.from(error));
         }
         if (catchTaskExecutor.isPresent()) {
           completable =
@@ -206,6 +206,14 @@ private CompletableFuture<WorkflowModel> handleException(
     return CompletableFuture.failedFuture(e);
   }
 
+  private static record WorkflowErrorExpr(
+      String type, int status, String instance, String title, String details) {
+    static WorkflowErrorExpr from(WorkflowError error) {
+      return new WorkflowErrorExpr(
+          error.type(), error.status(), error.instance(), error.title(), error.detail());
+    }
+  }
+
   private static Optional<Predicate<WorkflowError>> buildErrorFilter(CatchErrors errors) {
     return errors != null
         ? Optional.of(error -> filterError(error, errors.getWith()))
@@ -217,7 +225,7 @@ private static boolean filterError(WorkflowError error, ErrorFilter errorFilter)
         && (errorFilter.getStatus() <= 0 || error.status() == errorFilter.getStatus())
         && compareString(errorFilter.getInstance(), error.instance())
         && compareString(errorFilter.getTitle(), error.title())
-        && compareString(errorFilter.getDetails(), error.details());
+        && compareString(errorFilter.getDetails(), error.detail());
   }
 
   private static boolean compareString(String one, String other) {

impl/core/src/main/java/io/serverlessworkflow/impl/lifecycle/ce/AbstractLifeCyclePublisher.java

@@ -15,8 +15,8 @@
  */
 package io.serverlessworkflow.impl.lifecycle.ce;
 
+import static io.serverlessworkflow.impl.WorkflowError.error;
 import static io.serverlessworkflow.impl.lifecycle.ce.WorkflowDefinitionCEData.ref;
-import static io.serverlessworkflow.impl.lifecycle.ce.WorkflowErrorCEData.error;
 
 import io.cloudevents.CloudEvent;
 import io.cloudevents.CloudEventData;

impl/core/src/main/java/io/serverlessworkflow/impl/lifecycle/ce/TaskFailedCEData.java

@@ -15,11 +15,12 @@
  */
 package io.serverlessworkflow.impl.lifecycle.ce;
 
+import io.serverlessworkflow.impl.WorkflowError;
 import java.time.OffsetDateTime;
 
 public record TaskFailedCEData(
     String workflow,
     String task,
     WorkflowDefinitionCEData definition,
     OffsetDateTime faultedAt,
-    WorkflowErrorCEData error) {}
+    WorkflowError error) {}

impl/core/src/main/java/io/serverlessworkflow/impl/lifecycle/ce/WorkflowErrorCEData.java

@@ -15,10 +15,11 @@
  */
 package io.serverlessworkflow.impl.lifecycle.ce;
 
+import io.serverlessworkflow.impl.WorkflowError;
 import java.time.OffsetDateTime;
 
 public record WorkflowFailedCEData(
     String name,
     WorkflowDefinitionCEData definition,
     OffsetDateTime faultedAt,
-    WorkflowErrorCEData error) {}
+    WorkflowError error) {}

impl/core/src/main/java/io/serverlessworkflow/impl/lifecycle/ce/WorkflowFailedCEData.java

@@ -28,6 +28,7 @@
 import io.serverlessworkflow.impl.WorkflowApplication;
 import io.serverlessworkflow.impl.WorkflowDefinition;
 import io.serverlessworkflow.impl.WorkflowDefinitionId;
+import io.serverlessworkflow.impl.WorkflowError;
 import io.serverlessworkflow.impl.WorkflowInstance;
 import io.serverlessworkflow.impl.WorkflowModel;
 import io.serverlessworkflow.impl.WorkflowStatus;
@@ -38,7 +39,6 @@
 import io.serverlessworkflow.impl.lifecycle.ce.TaskStartedCEData;
 import io.serverlessworkflow.impl.lifecycle.ce.WorkflowCancelledCEData;
 import io.serverlessworkflow.impl.lifecycle.ce.WorkflowCompletedCEData;
-import io.serverlessworkflow.impl.lifecycle.ce.WorkflowErrorCEData;
 import io.serverlessworkflow.impl.lifecycle.ce.WorkflowFailedCEData;
 import io.serverlessworkflow.impl.lifecycle.ce.WorkflowResumedCEData;
 import io.serverlessworkflow.impl.lifecycle.ce.WorkflowStartedCEData;
@@ -225,7 +225,7 @@ void testError() throws IOException {
                 CompletionException.class,
                 () -> appl.workflowDefinition(workflow).instance(Map.of()).start().join()))
         .isNotNull();
-    WorkflowErrorCEData error =
+    WorkflowError error =
         assertPojoInCE("io.serverlessworkflow.workflow.faulted.v1", WorkflowFailedCEData.class)
             .error();
     assertThat(error.type()).isEqualTo("https://serverlessworkflow.io/errors/not-implemented");

impl/test/src/test/java/io/serverlessworkflow/impl/test/LifeCycleEventsTest.java

@@ -204,7 +204,7 @@ private static void checkWorkflowException(WorkflowException ex) {
         .isEqualTo("https://serverlessworkflow.io/errors/not-implemented");
     assertThat(ex.getWorkflowError().status()).isEqualTo(500);
     assertThat(ex.getWorkflowError().title()).isEqualTo("Not Implemented");
-    assertThat(ex.getWorkflowError().details()).contains("raise-not-implemented");
+    assertThat(ex.getWorkflowError().detail()).contains("raise-not-implemented");
     assertThat(ex.getWorkflowError().instance()).isEqualTo("do/0/notImplemented");
   }