Skip to content

Commit 7ebe133

Browse files
committed
fix(CLI): Fix handling of provider URL handling
1 parent 80fef65 commit 7ebe133

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

lib/cli/interactive-setup/aws-credentials.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ const steps = {
210210
},
211211
handleProviderCreation: async ({ configuration: { org: orgName }, stepHistory }) => {
212212
const providersUrl = `https://app.serverless.com/${orgName}/settings/providers?source=cli&providerId=new&provider=aws`;
213-
openBrowser(chalk.bold.white(providersUrl));
213+
openBrowser(providersUrl);
214214
legacy.write('To learn more about providers, visit: http://slss.io/add-providers-dashboard\n');
215215
log.notice('To learn more about providers, visit: http://slss.io/add-providers-dashboard');
216216
legacy.write('\nWaiting for creation of AWS Access Role provider...\n');

test/unit/lib/cli/interactive-setup/aws-credentials.test.js

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ const proxyquire = require('proxyquire');
66
const overrideEnv = require('process-utils/override-env');
77
const overrideStdoutWrite = require('process-utils/override-stdout-write');
88
const requireUncached = require('ncjsm/require-uncached');
9-
const chalk = require('chalk');
109
const { StepHistory } = require('@serverless/utils/telemetry');
1110

1211
const { expect } = chai;
@@ -485,9 +484,7 @@ describe('test/unit/lib/cli/interactive-setup/aws-credentials.test.js', () => {
485484

486485
expect(stdoutData).to.include('AWS Access Role provider was successfully created');
487486
expect(mockedOpenBrowser).to.have.been.calledWith(
488-
chalk.bold.white(
489-
'https://app.serverless.com/someorg/settings/providers?source=cli&providerId=new&provider=aws'
490-
)
487+
'https://app.serverless.com/someorg/settings/providers?source=cli&providerId=new&provider=aws'
491488
);
492489
expect(mockedDisconnect).to.have.been.called;
493490
expect(mockedCreateProviderLink).not.to.have.been.called;
@@ -562,9 +559,7 @@ describe('test/unit/lib/cli/interactive-setup/aws-credentials.test.js', () => {
562559

563560
expect(stdoutData).to.include('AWS Access Role provider was successfully created');
564561
expect(mockedOpenBrowser).to.have.been.calledWith(
565-
chalk.bold.white(
566-
'https://app.serverless.com/someorg/settings/providers?source=cli&providerId=new&provider=aws'
567-
)
562+
'https://app.serverless.com/someorg/settings/providers?source=cli&providerId=new&provider=aws'
568563
);
569564
expect(mockedDisconnect).to.have.been.called;
570565
expect(mockedCreateProviderLink).to.have.been.calledWith(
@@ -618,9 +613,7 @@ describe('test/unit/lib/cli/interactive-setup/aws-credentials.test.js', () => {
618613

619614
expect(stdoutData).to.include('Serverless Dashboard is currently unavailable');
620615
expect(mockedOpenBrowser).to.have.been.calledWith(
621-
chalk.bold.white(
622-
'https://app.serverless.com/someorg/settings/providers?source=cli&providerId=new&provider=aws'
623-
)
616+
'https://app.serverless.com/someorg/settings/providers?source=cli&providerId=new&provider=aws'
624617
);
625618
expect(context.stepHistory.valuesMap()).to.deep.equal(
626619
new Map([['credentialsSetupChoice', '_create_provider_']])

0 commit comments

Comments
 (0)