Skip to content

Update dependencies, make TypeScript a peer dependency #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

JackCuthbert
Copy link
Contributor

@JackCuthbert JackCuthbert commented Apr 1, 2019

In order to get things moving and learn my way around being a new maintainer, I'm updating the dependencies to bring us back to the present and solve an issue that's been bugging me personally 🚀

Includes changes:

  • Update all the things to their latest versions
  • ts-jest at version 24 supplies a preset for Jest 24s new preset option, documentation
  • Updated the testRegex configuration to only pay attention to *.ts files for tests, it was running both js and ts files before.
  • Made typescript >= 2.2.2 a peer dependency which should close out Typescript needs to be a peer dependency #112 and make the plugin a little more flexible for folks on newer versions

The builds only fail on node 9 as a newer package depends on LTS releases only, should we update the travis pipelines to test only LTS as well? Especially considering GCP and AWS support only LTS releases AFAIK.

@JackCuthbert JackCuthbert requested a review from divyenduz April 1, 2019 10:31
@divyenduz
Copy link
Contributor

@JackCuthbert : Is there an alternative to this new package that works for more node versions? Node 9 is recent enough and people might want to use that. Let us see if we can support that :)

@JackCuthbert
Copy link
Contributor Author

Is there an alternative to this new package that works for more node versions? Node 9 is recent enough and people might want to use that. Let us see if we can support that :)

@divyenduz, it looks like the package requiring an LTS node (sane@4.x) is required by Jest 24 (via jest-haste-map) which is not used in the plugin itself. To resolve this we'd have to use Jest < 24.

I'd personally prefer to keep things up to date and add node 10 to the list of tests replacing node 9. What do you think?

@JackCuthbert JackCuthbert force-pushed the update-dependencies branch from d115e97 to 03f19a6 Compare April 1, 2019 22:52
@divyenduz
Copy link
Contributor

Sounds great, let us circle back on this if people want node 9 support, merging this one for now.

@divyenduz divyenduz merged commit 2045258 into master Apr 4, 2019
@JackCuthbert JackCuthbert deleted the update-dependencies branch April 4, 2019 08:49
@divyenduz
Copy link
Contributor

🎉 This PR is included in version 1.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants