Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Integration tests + tag if new version #656

Merged
merged 39 commits into from
May 15, 2023

Conversation

gligorkot
Copy link
Contributor

@gligorkot gligorkot commented May 13, 2023

What did you implement:

Closes #645

Updated integration tests workflow to run node and python integration tests, but only barely - removed the tests that were trying to deploy to Azure. Node workflow also runs validation script and the node tests.

Note:

The "Tag if new version" job runs as per Serverless framework repo here https://github.com/serverless/serverless/blob/a6bcc62182b6fe974d12d547c00e560882c55e05/.github/workflows/integrate.yml#L171.

In order for this to job to work a USER_GITHUB_TOKEN secret needs to be added with the 'serverless-ci' user authentication token as per Serverless framework. As per https://github.com/serverless/serverless/blob/a6bcc62182b6fe974d12d547c00e560882c55e05/.github/workflows/integrate.yml#L188-L190

How did you implement it:

Added integration.yml in the github workflows.

How can we verify it:

The workflow will run once the PR has been merged, but you can verify the last run in my repository here https://github.com/gligorkot/serverless-azure-functions/actions/runs/4964935025

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

  • Ensure there are no lint errors.
    Validate via npm run lint
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

gligorkot added 30 commits March 1, 2023 09:08
…ackage lock for all integration configurations
…elative path serverless azure functions package
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me. Thank you @gligorkot !

@medikoo medikoo merged commit 5108019 into serverless:master May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI setup. Ensure working builds
2 participants