This repository was archived by the owner on Dec 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 160
Integration tests + tag if new version #656
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to the github token
…ackage lock for all integration configurations
…elative path serverless azure functions package
…n't work anymore for the parent repo
…pack builds (not sure this will work)
Latest master
…ion tests to run validate steps
…ined in the integration workflow)
…o if one is detected in package.json
medikoo
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me. Thank you @gligorkot !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #645
Updated integration tests workflow to run node and python integration tests, but only barely - removed the tests that were trying to deploy to Azure. Node workflow also runs validation script and the node tests.
Note:
The "Tag if new version" job runs as per Serverless framework repo here https://github.com/serverless/serverless/blob/a6bcc62182b6fe974d12d547c00e560882c55e05/.github/workflows/integrate.yml#L171.
In order for this to job to work a
USER_GITHUB_TOKEN
secret needs to be added with the 'serverless-ci' user authentication token as per Serverless framework. As per https://github.com/serverless/serverless/blob/a6bcc62182b6fe974d12d547c00e560882c55e05/.github/workflows/integrate.yml#L188-L190How did you implement it:
Added integration.yml in the github workflows.
How can we verify it:
The workflow will run once the PR has been merged, but you can verify the last run in my repository here https://github.com/gligorkot/serverless-azure-functions/actions/runs/4964935025
Todos:
Note: Run
npm run test:ci
to run all validation checks on proposed changesValidate via
npm run lint
Note: Some reported issues can be automatically fixed by running
npm run lint:fix
Validate via
npm test
Is this ready for review?: YES
Is it a breaking change?: NO