This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Publish script #653
Merged
Publish script #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to the github token
|
@medikoo any chance you can please have a look at this one and merge if acceptable or let me know what else you'd like to change before we can merge it in? |
Closed
weisurya
previously approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Hi @medikoo - when you have time, would you mind to take a look into this PR? It would be great if we could use node18 for Azure functions
It's reaching to EoL as stated here
#654 (comment)
medikoo
suggested changes
May 8, 2023
There was a problem hiding this comment.
@gligorkot great thanks for that PR, and sorry for late review (I was on vacation and then I was catching up)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #645 and #654
How did you implement it:
Adding a publish github action that runs on version tag.
How can we verify it:
Add a tag that follows semver format vX.X.X
Todos:
Note: Run
npm run test:cito run all validation checks on proposed changesValidate via
npm run lintNote: Some reported issues can be automatically fixed by running
npm run lint:fixValidate via
npm testIs this ready for review?: YES
Is it a breaking change?: NO