This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Adding support for nodejs16 and nodejs18 #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
suggested changes
Feb 23, 2023
| @@ -80,7 +80,7 @@ describe("Function App Resource", () => { | |||
| const config = getConfig(FunctionAppOS.LINUX, Runtime.PYTHON36); | |||
|
|
|||
| const resource = new FunctionAppResource(); | |||
|
|
|||
There was a problem hiding this comment.
Let's not introduce unrelated changes
package-lock.json
Outdated
| @@ -5,7 +5,8 @@ | |||
| "requires": true, | |||
| "packages": { | |||
| "": { | |||
| "version": "2.1.0", | |||
There was a problem hiding this comment.
Let's not introduce changes to this file
|
@medikoo this is now updated and ready for re-review |
|
@medikoo any chance we can get a new release tagged for these changes you've just merged please? 🙏 |
|
@gligorkot Currently validating this repository is broken, and i think we should fix it before pursuing any release. I've created an issue describing what needs to be done: #645 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Adding support for Nodejs 18
How did you implement it:
Following a template that others have followed
How can we verify it:
Use it to deploy a nodejs18 function app to Azure.
Todos:
Note: Run
npm run test:cito run all validation checks on proposed changesValidate via
npm run lintNote: Some reported issues can be automatically fixed by running
npm run lint:fixValidate via
npm testIs this ready for review?: YES
Is it a breaking change?: NO