Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

feat: add suport for node16 runtime #640

Merged
merged 10 commits into from
Feb 24, 2023
Merged

Conversation

lcsales98
Copy link
Contributor

@lcsales98 lcsales98 commented Feb 2, 2023

What did you implement:

Closes #631

It will become available to use the nodejs16 runtime.

How did you implement it:

I'm updated the available runtimes at src/config/runtime.ts.

How can we verify it:

Can you generate an azure function with serverless-framework and deploy it with nodejs16 runtime.
Ex: runtime: nodejs16

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

  • Ensure there are no lint errors.
    Validate via npm run lint
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lcsales98! Please see my comments

@lcsales98 lcsales98 requested a review from medikoo February 7, 2023 15:54
@danielwaghorn
Copy link

Are there any updates on being able to get this merged at all? Happy to help if required.

@medikoo
Copy link
Contributor

medikoo commented Feb 24, 2023

Are there any updates on being able to get this merged at all? Happy to help if required.

The only problem was that author of PR didn't mark this PR as ready for re-review. Anyway it looks as good to take

@medikoo medikoo merged commit 33f82d2 into serverless:master Feb 24, 2023
@medikoo
Copy link
Contributor

medikoo commented Feb 24, 2023

I've merged it, yet it doesn't seem to be validated in CI, and locally for me tests fails.

Before releasing it, it'll be good to fix the CI in this project (I've created an issue: #645) and ensure that locally all tests passes

@gligorkot gligorkot mentioned this pull request May 25, 2023
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add suport for Node.js 16
3 participants