Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash deployment if function app zip file doesn't exist #242

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Aug 16, 2019

With package.individually the expected function app zip file is not generated in form supported by a plugin.

In such case currently plugin just logs some error message as follows:

Function app zip file '/Users/medikoo/Projects/tests/serverless-azure/.serverless/test-azure-0x.zip' does not exist

but doesn't exit with an error, which gives a confusing impression.

This PR ensures that such scenario is reported with plugin error

@medikoo medikoo added the bug label Aug 16, 2019
@medikoo medikoo self-assigned this Aug 16, 2019
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbarlow12 tbarlow12 merged commit c79e27f into dev Aug 16, 2019
@tbarlow12 tbarlow12 deleted the medikoo/fix-deploy-error-handling branch September 16, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants