feat: Cache interactive login credentials #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
suggested changes
Aug 2, 2019
| const CONFIG_DIRECTORY = path.join(os.homedir(), ".azure"); | ||
| const SLS_TOKEN_FILE = path.join(CONFIG_DIRECTORY, "slsTokenCache.json"); | ||
|
|
||
| export class SimpleFileTokenCache { |
There was a problem hiding this comment.
Is there an actual interface type definition that we can reference here?
pjlittle
reviewed
Aug 2, 2019
pjlittle
reviewed
Aug 2, 2019
wbreza
suggested changes
Aug 8, 2019
mydiemho
approved these changes
Aug 8, 2019
| this.load(); | ||
| } | ||
|
|
||
| public add(entries: any, cb?: any) { |
There was a problem hiding this comment.
what's cb? a more descriptive name would be better
There was a problem hiding this comment.
it's a callback, I'll switch the name
| } | ||
| } | ||
|
|
||
| public remove(entries: any, cb?: any) { |
| } | ||
| } | ||
|
|
||
| public find(query: any, cb?: any) { |
|
|
||
| //-------- File toke cache specific methods | ||
|
|
||
| public addSubs(entries: any) { |
There was a problem hiding this comment.
does entries change? can we be more specific than just default to any?
|
|
||
| public addSubs(entries: any) { | ||
| this.subscriptions.push(...entries); | ||
| this.subscriptions = this.subscriptions.reduce((acc, current) => { |
There was a problem hiding this comment.
it's the accumulator for the reducer, not a very exciting name haha
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
* Add simple file token cache * Address pr feedback * Added tests for existing and nonexisting cached login * Cleaned up cached login test for login service * Clean up simpleFileTokenCache, add tests * Add param to simpleFileTokenCache constructor for path * Updated simple file token cache tests * Restore fs mocks at end of each test * Fix getTokens in mock * Fixing broken tests * Address pr feedback * Pushing again * Address more pr feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Cache interactive login credentials
Currently once a user logs in using the interactive login, there is no way to cache the credentials and the user must keep logging in through that method. This adds a simple file token cache that saves the credentials and subscription information and then uses those to login, reducing number of logins required.
AB#359