This repository was archived by the owner on Dec 9, 2024. It is now read-only.
fix: Update storage account naming convention #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydiemho
approved these changes
Jul 5, 2019
| Guard.empty(longName); | ||
| Guard.null(wellKnownMap); | ||
|
|
||
| const pattern = `(${Object.keys(wellKnownMap).join("|")})`; |
There was a problem hiding this comment.
it would be good to have comments explaining what these pattern and regex do
wbreza
force-pushed
the
wabrez/fix-storage-account-name
branch
from
3fff350 to
7d49677
Compare
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
Ensures storage account names do not clash based on combination of prefix, region, stage & service name - Ensures generated name is <= 24 chars - Ensures region names don't conflict - Generates short region part from full value - Generates short stage part from full value - Includes partial hash of service name in full name Resolves AB#420
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures storage account names do not clash based on combination of prefix, region, stage & service name
Resolves AB#420