Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enabled Jest configuration to work in VS code #146

Merged
merged 1 commit into from
May 23, 2019
Merged

feat: Enabled Jest configuration to work in VS code #146

merged 1 commit into from
May 23, 2019

Conversation

wbreza
Copy link
Contributor

@wbreza wbreza commented May 23, 2019

  • Changed jest config to js from json (VS code looks for js file)
  • Added serverless as dev dependency
  • Added unit test to validate configuration

@wbreza wbreza changed the base branch from master to dev May 23, 2019 17:15
tbarlow12
tbarlow12 approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbarlow12 tbarlow12 merged commit aa18021 into dev May 23, 2019
@wbreza wbreza deleted the wabrez/jest-config branch May 23, 2019 17:21
mydiemho pushed a commit that referenced this pull request May 24, 2019
@wbreza @mydiemho
feat: Enabled jest configuration to work in VS code (#146)
40fbf36
tbarlow12 pushed a commit that referenced this pull request Sep 13, 2019
@wbreza @tbarlow12
feat: Enabled jest configuration to work in VS code (#146)
d318a4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbarlow12 tbarlow12 tbarlow12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbreza @tbarlow12