feat: support loading config from JS and JSON files #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@horike37 @theburningmonk Could I get a review on this. Seems it is a feature that has been desired since January of last year. |
|
@duro thanks for the PR, it looks fine to me at a glance, have you tried it out with an actual serverless.js file to see if it works? (problem with a lot of these tests is that it's not really testing the bit I'm interested in since they're stubbed out) |
|
@theburningmonk, yes, in fact I'm already using my fork in a project |
|
🎉 This PR is included in version 2.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ss-betseqnzr
pushed a commit
to BetSEQNZR/serverless-step-functions
that referenced
this pull request
Sep 8, 2023
feat: support loading config from JS and JSON files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon what was started in PR #159 and adds tests
Fixes: #292