Honor selected content upon input (Issue #214) #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This addresses issue serso#214 of the upstream GitHub project: serso#214 When text is selected in the editor input field, pressing a key will now behave differently from when no text is selected. * When pressing a digit or pasting text, the selected text will be replaced with the cursor to the right of the inserted text. * When hitting backspace, the selected text will be erased without deleting the character left of the selection. * When cutting selected text, the cursor will stay at the start of the original selection. * When pressing an operator, the selected text will be put into parentheses and the cursor will be placed after these and the operator. * When pressing parentheses, the selected text will be put in parentheses and the cursor will be placed after them. The behavior with no text selected stays the same, i.e. the text cursor will be put inside of the parentheses when inserting them, backspace will erase the content left to the cursor.
lineinthesand
force-pushed
the
master
branch
from
6a2746f to
36d7c0d
Compare
|
Can you give me a copy of your app |
|
@Boldan I could try, but it would only be a debug version https://tinyurl.com/calculatorpp |
Well, my phone can't install it😂 |
|
It could be you'd have to uninstall the one from f-droid first and/or allow other sources for installing apk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #214. Making an input/erasing with a selection in the editor now makes a difference when compared to no selection (e.g. adding parentheses/erasing the selected content etc.)
Note that I was not able to build the project cloned from github, only the one from https://git.bubu1.eu/Bubu/android-calculatorpp, so I do not know whether my changes actually work with this version. They do with the bubu version, as far as I have tested them.
@serso could you probably help me with building the github version of the calculator or publish some build instructions? That would be great! Thanks a lot.