Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slow diff view for big revision #1313

Closed
Entkenntnis opened this issue Oct 4, 2021 · 3 comments
Closed

slow diff view for big revision #1313

Entkenntnis opened this issue Oct 4, 2021 · 3 comments

Comments

@Entkenntnis
Copy link
Member

interesting find in the wild: https://de.serlo.org/entity/repository/compare/1571/225401 is very slow if you switch to "Quelltext" - at least for me on FF, Linux
@elbotho
Copy link
Member

elbotho commented Oct 4, 2021

Can reproduce. Chrome/chromium is a bit quicker. Maybe 4-5s on my laptop?
I think it's quite okay since it's usually a lot faster. Do you see any need to optimize?

@Entkenntnis Entkenntnis changed the title very slow diff view for big revision slow diff view for big revision Oct 4, 2021
@Entkenntnis
Copy link
Member Author

upstream issue: praneshr/react-diff-viewer#25

@elbotho
Copy link
Member

elbotho commented Nov 10, 2021

I'll close this for now since there is nothing for us to do atm imo.
I hope react-diff or js-diff will choose the faster package and this will be resolved with some updating in the future.
Reopen if you disagree :)

@elbotho elbotho closed this as completed Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elbotho @Entkenntnis