added stringification support #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
reviewed
Nov 28, 2019
| @@ -78,6 +78,11 @@ public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Except | |||
| if (logger.BindProperty(property.Key.Substring(1), property.Value, true, out var destructured)) | |||
| properties.Add(destructured); | |||
| } | |||
| else if (property.Key.StartsWith("$")) | |||
| { | |||
| if (logger.BindProperty(property.Key.Substring(1), property.Value?.ToString() ?? "null", true, out var stringified)) | |||
There was a problem hiding this comment.
Substituting in the text null will be inconsistent with Serilog here, I think. We should just pass null if property.Value is null.
|
@jonnybi hi! I just spotted one more place where we special-case |
|
@nblumhardt thx for spotting this. i will check it |
nblumhardt
reviewed
Dec 6, 2019
| @@ -78,6 +78,11 @@ public void EnrichAndCreateScopeItem(LogEvent logEvent, ILogEventPropertyFactory | |||
| destructureObject = true; | |||
| } | |||
|
|
|||
| if (key.StartsWith("$")) | |||
| { | |||
| key = key.Substring(1); | |||
There was a problem hiding this comment.
The value would also have to be ToString()ed in order for this to take effect.
There was a problem hiding this comment.
sry, i was a little too fast. Fixed it again and added a unit test.
|
Thanks! 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "force stringification" support as described in serilog documentation.