Skip to content

Upgraded Microsoft.Extensions.Logging NuGet packages to 2.0.0 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2019

Conversation

DigiBanks99
Copy link
Contributor

With regards to Issue: #115

I have bumped the versions of the Microsoft.Extensions.Logging and Microsoft.Extensions.Logging.Abstractions libraries to 2.0.0 for .net standard and .net framework 4.61. I've also bumped Serilog to 2.8.0.

@nblumhardt
Copy link
Member

Thanks @DigiBanks99 !

Re-reading, I think the intent of #115 is to use a single dependency version across all target frameworks; perhaps we should make the break in a new major version, and just drop support (from the current version of the package) for TFMs that Microsoft.Extensions.Logging 2.0 doesn't reach? 🤔

@DigiBanks99
Copy link
Contributor Author

@nblumhardt Hmmm... Yeah, That makes more sense. I'll do it that way then.

@DigiBanks99
Copy link
Contributor Author

The Microsoft.Extensions.Logging.Abstractions versions seems to be very inconsistent across the various Serilog projects, as seen here, so I'm not really sure if I should bump it to 2.1.0 at the very least and maybe update the remaining repositories as well?

@nblumhardt
Copy link
Member

@DigiBanks99 I think aiming for consistency will only make a temporary improvement, since the various projects move forwards at their own cadence - I think making the changes here, first, is a good start :-) 👍

@nblumhardt
Copy link
Member

I've had another look at this and think we should release it as a 3.0, along with (I guess) a dependency on the 3.0 MEL packages. Looking at v2 of MEL, there's no separate .NET Framework target anymore, so no point maintaining that here, either.

I've just pushed a release from dev -> master, if that's all successful I think we can get this onto dev and start shaping up the v3 👍

@nblumhardt nblumhardt merged commit e85c32f into serilog:dev May 21, 2019
@nblumhardt nblumhardt mentioned this pull request Aug 19, 2019
@nblumhardt nblumhardt added this to the 3.0.0 milestone Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants