3.4.1 Release

[nblumhardt]

• Enable wildcard indexers over dictionary elements #77 - enable wildcard indexers over dictionary values (@nblumhardt)
• file scoped namespace and target typed new #79 - use file-scoped namespaces and target-typed new (@SimonCropp)
• step sample project target framework from net5.0 to net.6.0 #82 - sample project retargeting (@jesseclm)
• Add a recipie for checking if an object is empty #80 - recipe for checking whether any unreferenced properties exist (@adamchester)

[SimonCropp]

Suggested change

	public override bool TryResolveFunctionName(string name, [MaybeNullWhen(false)] out MethodInfo implementation)
	public override bool TryResolveFunctionName(string name, [NotNullWhen(true)] out MethodInfo? implementation)

[nblumhardt]

Thanks - agreed, but actually needs a major version bump to work, I think (I tried earlier :-)) so may have to wait for a follow-up

[AraHaan]

I do not think changing the attribute would be breaking at all though, same with changing from non-nullable to nullable.

Plus it is in tests so I do not think people outside of the repository would use it anyway.

[SimonCropp]

but actually needs a major version bump to work

why?

note that nullable ref types is implemented using attributes. so it is not a runtime breaking change.

here is what it actually compiles to

public override bool TryResolveFunctionName(string name, [System.Runtime.CompilerServices.Nullable(2)][NotNullWhen(true)] out MethodInfo implementation)
{
	NameResolver[] orderedResolvers = _orderedResolvers;
	foreach (NameResolver resolver in orderedResolvers)
	{
		if (resolver.TryResolveFunctionName(name, out implementation))
		{
			return true;
		}
	}
	implementation = null;
	return false;
}

Arguably someone could be using the nullable implementation parameter without null checking it (or not inside an iff on the returned bool). but in that case we want it to break for them, since they have a bug

[nblumhardt]

Great point! Thanks 👍

[nblumhardt]

Just catching up now after a couple of weeks away - I'll leave this for the next round of changes so we can keep things moving here in the meantime :)