Add GetMessageTemplateProperties option #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you David 👍 |
|
Hi @nblumhardt any news on when this will be available in a new release? |
Merged
|
I've created the release PR now, @PeterZaal - thanks for the nudge! #310 Have you been using this successfully via the |
|
Hi @nblumhardt I am on the same team as @dnperfors who created this PR, and we use a copy of the modified files in our code, which works perfectly fine! |
| new LogEventProperty("RequestMethod", new ScalarValue(httpContext.Request.Method)), | ||
| new LogEventProperty("RequestPath", new ScalarValue(requestPath)), | ||
| new LogEventProperty("StatusCode", new ScalarValue(statusCode)), | ||
| new LogEventProperty("Elapsed", new ScalarValue(elapsedMs)) |
There was a problem hiding this comment.
for search requests we already have another name of the variable:
"Search request {OfferSearchId} finished processing in {RequestStatus} after {ElapsedMilliseconds:N0} ms"
should we change it there to Elapsed as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174