Prevent logging data from being affected by transactions. #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added class SqlConnectionStringBuilderWrapper to add Enlist= parameter. Used in in SqlConnectionFactory. * Added new sink option PreventEnlistInTransaction in code and documented it in README. * Tests
…nfiguration sources.
jonorossi
requested changes
Feb 27, 2022
src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/MSSqlServerSinkOptions.cs
Outdated
Show resolved
Hide resolved
* Renamed PreventEnlistInTransactions to EnlistInTransaction and changed default to false. * Fixed typos in README.
…run from all other tests to avoid side effects with other DB tests. Ugly but the only feasible way to get this stable.
jonorossi
previously approved these changes
Mar 6, 2022
* Increased connection timeout when deleting or creating DB in DB tests (enables stable parallel execution of all DB tests including the transaction test). * Let all tests execute in one run again. No more separation of transaction DB test necessary.
ckadluba
force-pushed
the
feature/enlist-false-enhanced
branch
from
cf92489
to
11cb6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sink now adds ";Enlist=False" to the connection string which avoids that logging SQL commands take part in ambient transactions (e.g. by TransactionScopes in the caller's program).
This is done by default but it can be turned off by setting the new sink option
EnlistInTransactionto true.Additionally all tests are now also executed for .NET Framework 4.7.2. With that the test run for all target frameworks of the sink.
Original input and implementation came from @Daniel-Svensson in pr #379 but had to be changed a bit and therefore commited with this pr.