Skip to content

Allow opening after an open error. #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2016
Merged

Allow opening after an open error. #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/serialport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,13 +222,13 @@ SerialPort.prototype.open = function(callback) {
this.opening = true;

SerialPortBinding.open(this.path, this.options, function(err, fd) {
this.opening = false;
if (err) {
debug('SerialPortBinding.open had an error', err);
return this._error(err, callback);
}
this.fd = fd;
this.paused = false;
this.opening = false;

if (process.platform !== 'win32') {
this.serialPoller = new SerialPortBinding.SerialportPoller(this.fd, function(err) {
Expand Down
12 changes: 12 additions & 0 deletions test/serialport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,18 @@ describe('SerialPort', function() {
port.open(spy);
port.open(spy);
});

it('allows opening after an open error', function(done) {
var stub = sandbox.stub(bindings, 'open', function(path, opt, cb) {
cb(new Error('haha no'));
});
var port = new SerialPort('/dev/exists', { autoOpen: false });
port.open(function(err) {
assert.instanceOf(err, Error);
stub.restore();
port.open(done);
});
});
});

describe('#close', function() {
Expand Down