Friendly name support for all platforms #219
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add friendlyname support for Mac & Linux - filter out inactive ports (Linux only)
|
This feature also requires a change in bindings-interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds / fixes friendly name support for all platforms.
Windows:
Friendly names were already supported, but it would just show the generic name (like "USB Serial Device" or "USB Serial Port").
This was changed to showing the device string (in USB CDC devices) if available.
Mac:
Friendly name support was added, showing the USB device string if available.
Linux:
As for Mac.
In addition, filtering for active serial ports was added, whereas previously a long list of inactive ttys was returned.
This ensures behavior that is consistent with the other platforms.