You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 9, 2020. It is now read-only.
Hello,
thanks for this library.
One small bug I discovered, there is an incorrect pinning a section, if list contains only Sections.
As you can see, Section 'O' is incorrectly pinned and not moved away. This happens only at the end of the list, with last shown item.
Correctly, it should be shown like this
I found out, issue is caused by wrong compare sign in method
int findFirstVisibleSectionPosition(int firstVisibleItem, int visibleItemCount)
at line 282, currently there is
if (firstVisibleItem + visibleItemCount >= adapter.getCount()) return -1; // dataset has changed, no candidate
and shoud be
if (firstVisibleItem + visibleItemCount > adapter.getCount()) return -1; // dataset has changed, no candidate
After shis adjustment, sections are shown correctly even in case shown above and there was no problem even in stadard use cases.
Hope, this will help someone.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hello,
thanks for this library.
One small bug I discovered, there is an incorrect pinning a section, if list contains only Sections.
As you can see, Section 'O' is incorrectly pinned and not moved away. This happens only at the end of the list, with last shown item.
Correctly, it should be shown like this
I found out, issue is caused by wrong compare sign in method
int findFirstVisibleSectionPosition(int firstVisibleItem, int visibleItemCount)
at line 282, currently there is
if (firstVisibleItem + visibleItemCount >= adapter.getCount()) return -1; // dataset has changed, no candidate
and shoud be
if (firstVisibleItem + visibleItemCount > adapter.getCount()) return -1; // dataset has changed, no candidate
After shis adjustment, sections are shown correctly even in case shown above and there was no problem even in stadard use cases.
Hope, this will help someone.
The text was updated successfully, but these errors were encountered: