Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serde-rs/serde
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.205
Choose a base ref
...
head repository: serde-rs/serde
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.206
Choose a head ref
  • 10 commits
  • 12 files changed
  • 3 contributors

Commits on Aug 9, 2024

  1. Add regression test for issue #2565

    failures (1):
        regression::issue2565::simple_variant
    Mingun committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    24614e4 View commit details
    Browse the repository at this point in the history
  2. Add regression test for issue #1904

    Currently panics in derive:
    
    error: proc-macro derive panicked
        --> test_suite\tests\test_annotations.rs:2386:25
         |
    2386 |     #[derive(Serialize, Deserialize, PartialEq, Debug)]
         |                         ^^^^^^^^^^^
         |
         = help: message: assertion failed: !cattrs.has_flatten()
    
    error: proc-macro derive panicked
      --> test_suite\tests\regression\issue1904.rs:57:10
       |
    57 | #[derive(Deserialize)]
       |          ^^^^^^^^^^^
       |
       = help: message: assertion failed: !cattrs.has_flatten()
    
    error: proc-macro derive panicked
      --> test_suite\tests\regression\issue1904.rs:47:10
       |
    47 | #[derive(Deserialize)]
       |          ^^^^^^^^^^^
       |
       = help: message: assertion failed: !cattrs.has_flatten()
    
    error: proc-macro derive panicked
      --> test_suite\tests\regression\issue1904.rs:37:10
       |
    37 | #[derive(Deserialize)]
       |          ^^^^^^^^^^^
       |
       = help: message: assertion failed: !cattrs.has_flatten()
    
    error: proc-macro derive panicked
      --> test_suite\tests\regression\issue1904.rs:27:10
       |
    27 | #[derive(Deserialize)]
       |          ^^^^^^^^^^^
       |
       = help: message: assertion failed: !cattrs.has_flatten()
    
    error: proc-macro derive panicked
      --> test_suite\tests\regression\issue1904.rs:16:10
       |
    16 | #[derive(Deserialize)]
       |          ^^^^^^^^^^^
       |
       = help: message: assertion failed: !cattrs.has_flatten()
    
    error: proc-macro derive panicked
     --> test_suite\tests\regression\issue1904.rs:7:10
      |
    7 | #[derive(Deserialize)]
      |          ^^^^^^^^^^^
      |
      = help: message: assertion failed: !cattrs.has_flatten()
    Mingun committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c3ac7b6 View commit details
    Browse the repository at this point in the history
  3. Correctly process flatten fields in enum variants

    - Fix incorrect deserialization of variants that doesn't contain flatten field when other contains
    - Fix a panic when deriving `Deserialize` for an enum with tuple and struct with flatten field
    
    Fixes (2):
        regression::issue2565::simple_variant
        regression::issue1904 (compilation)
    Mingun committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    b4ec259 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Configuration menu
    Copy the full SHA
    2afe5b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. Merge pull request #2567 from Mingun/fix-2565

    Correctly process flatten fields in enum variants
    dtolnay authored Aug 11, 2024
    Configuration menu
    Copy the full SHA
    fc55ac7 View commit details
    Browse the repository at this point in the history
  2. Temporarily ignore collection_is_never_read on FlattenSkipDeserializing

        error: collection is never read
           --> test_suite/tests/test_gen.rs:723:25
            |
        723 |     #[derive(Serialize, Deserialize)]
            |                         ^^^^^^^^^^^
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collection_is_never_read
        note: the lint level is defined here
           --> test_suite/tests/test_gen.rs:23:9
            |
        23  | #![deny(clippy::collection_is_never_read)]
            |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)
    dtolnay committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    536221b View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2794 from dtolnay/neverread

    Temporarily ignore collection_is_never_read on FlattenSkipDeserializing
    dtolnay authored Aug 11, 2024
    Configuration menu
    Copy the full SHA
    84c7419 View commit details
    Browse the repository at this point in the history
  4. Touch up PR 2567

    dtolnay committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    e52b7b3 View commit details
    Browse the repository at this point in the history
  5. Resolve doc_markdown pedantic lint on regression test function

        warning: you should put bare URLs between `<`/`>` or make a proper Markdown link
            --> test_suite/tests/test_annotations.rs:2383:25
             |
        2383 | /// Regression test for #1904
             |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `<https://github.com/serde-rs/serde/issues/1904>`
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
             = note: `-W clippy::doc-markdown` implied by `-W clippy::pedantic`
             = help: to override `-W clippy::pedantic` add `#[allow(clippy::doc_markdown)]`
    dtolnay committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    5ba1796 View commit details
    Browse the repository at this point in the history
  6. Release 1.0.206

    dtolnay committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    85c73ef View commit details
    Browse the repository at this point in the history
Loading