-
-
Notifications
You must be signed in to change notification settings - Fork 767
Comparing changes
Open a pull request
base repository: serde-rs/serde
base: v1.0.205
head repository: serde-rs/serde
compare: v1.0.206
- 10 commits
- 12 files changed
- 3 contributors
Commits on Aug 9, 2024
-
Add regression test for issue #2565
failures (1): regression::issue2565::simple_variant
Configuration menu - View commit details
-
Copy full SHA for 24614e4 - Browse repository at this point
Copy the full SHA 24614e4View commit details -
Add regression test for issue #1904
Currently panics in derive: error: proc-macro derive panicked --> test_suite\tests\test_annotations.rs:2386:25 | 2386 | #[derive(Serialize, Deserialize, PartialEq, Debug)] | ^^^^^^^^^^^ | = help: message: assertion failed: !cattrs.has_flatten() error: proc-macro derive panicked --> test_suite\tests\regression\issue1904.rs:57:10 | 57 | #[derive(Deserialize)] | ^^^^^^^^^^^ | = help: message: assertion failed: !cattrs.has_flatten() error: proc-macro derive panicked --> test_suite\tests\regression\issue1904.rs:47:10 | 47 | #[derive(Deserialize)] | ^^^^^^^^^^^ | = help: message: assertion failed: !cattrs.has_flatten() error: proc-macro derive panicked --> test_suite\tests\regression\issue1904.rs:37:10 | 37 | #[derive(Deserialize)] | ^^^^^^^^^^^ | = help: message: assertion failed: !cattrs.has_flatten() error: proc-macro derive panicked --> test_suite\tests\regression\issue1904.rs:27:10 | 27 | #[derive(Deserialize)] | ^^^^^^^^^^^ | = help: message: assertion failed: !cattrs.has_flatten() error: proc-macro derive panicked --> test_suite\tests\regression\issue1904.rs:16:10 | 16 | #[derive(Deserialize)] | ^^^^^^^^^^^ | = help: message: assertion failed: !cattrs.has_flatten() error: proc-macro derive panicked --> test_suite\tests\regression\issue1904.rs:7:10 | 7 | #[derive(Deserialize)] | ^^^^^^^^^^^ | = help: message: assertion failed: !cattrs.has_flatten()
Configuration menu - View commit details
-
Copy full SHA for c3ac7b6 - Browse repository at this point
Copy the full SHA c3ac7b6View commit details -
Correctly process flatten fields in enum variants
- Fix incorrect deserialization of variants that doesn't contain flatten field when other contains - Fix a panic when deriving `Deserialize` for an enum with tuple and struct with flatten field Fixes (2): regression::issue2565::simple_variant regression::issue1904 (compilation)
Configuration menu - View commit details
-
Copy full SHA for b4ec259 - Browse repository at this point
Copy the full SHA b4ec259View commit details
Commits on Aug 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2afe5b4 - Browse repository at this point
Copy the full SHA 2afe5b4View commit details
Commits on Aug 11, 2024
-
Merge pull request #2567 from Mingun/fix-2565
Correctly process flatten fields in enum variants
Configuration menu - View commit details
-
Copy full SHA for fc55ac7 - Browse repository at this point
Copy the full SHA fc55ac7View commit details -
Temporarily ignore collection_is_never_read on FlattenSkipDeserializing
error: collection is never read --> test_suite/tests/test_gen.rs:723:25 | 723 | #[derive(Serialize, Deserialize)] | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collection_is_never_read note: the lint level is defined here --> test_suite/tests/test_gen.rs:23:9 | 23 | #![deny(clippy::collection_is_never_read)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)
Configuration menu - View commit details
-
Copy full SHA for 536221b - Browse repository at this point
Copy the full SHA 536221bView commit details -
Merge pull request #2794 from dtolnay/neverread
Temporarily ignore collection_is_never_read on FlattenSkipDeserializing
Configuration menu - View commit details
-
Copy full SHA for 84c7419 - Browse repository at this point
Copy the full SHA 84c7419View commit details -
Configuration menu - View commit details
-
Copy full SHA for e52b7b3 - Browse repository at this point
Copy the full SHA e52b7b3View commit details -
Resolve doc_markdown pedantic lint on regression test function
warning: you should put bare URLs between `<`/`>` or make a proper Markdown link --> test_suite/tests/test_annotations.rs:2383:25 | 2383 | /// Regression test for #1904 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `<https://github.com/serde-rs/serde/issues/1904>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown = note: `-W clippy::doc-markdown` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::doc_markdown)]`
Configuration menu - View commit details
-
Copy full SHA for 5ba1796 - Browse repository at this point
Copy the full SHA 5ba1796View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85c73ef - Browse repository at this point
Copy the full SHA 85c73efView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.205...v1.0.206