Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serde-rs/serde
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.157
Choose a base ref
...
head repository: serde-rs/serde
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.158
Choose a head ref
  • 5 commits
  • 9 files changed
  • 1 contributor

Commits on Mar 20, 2023

  1. Add regression test for issue 2409

    @dtolnay
    dtolnay committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    c3d637f View commit details
    Browse the repository at this point in the history

  2. Check for None-delimited group in attribute value

    @dtolnay
    dtolnay committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    dd460f8 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2410 from serde-rs/attrvalue 

    Check for None-delimited group in attribute value
    @dtolnay
    dtolnay authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    2c0999a View commit details
    Browse the repository at this point in the history

  4. Reformat comments of non-public serde_derive internals 

    Fixes these being treated as "tests" by `cargo test` in serde_derive:

    running 3 tests
    test src/internals/check.rs - internals::check::check_remote_generic (line 23) ... FAILED
    test src/internals/check.rs - internals::check::check_remote_generic (line 29) ... FAILED
    test src/lib.rs - (line 3) ... ok

    failures:

    ---- src/internals/check.rs - internals::check::check_remote_generic (line 23) stdout ----
    error: unknown start of token: \u{2026}
     --> src/internals/check.rs:25:20
      |
    4 | struct Generic<T> {…}
      |                    ^

    error: cannot find attribute `serde` in this scope
     --> src/internals/check.rs:24:3
      |
    3 | #[serde(remote = "Generic")]
      |   ^^^^^
      |
      = note: `serde` is in scope, but it is a crate, not an attribute

    error[E0392]: parameter `T` is never used
     --> src/internals/check.rs:25:16
      |
    4 | struct Generic<T> {…}
      |                ^ unused parameter
      |
      = help: consider removing `T`, referring to it in a field, or using a marker such as `PhantomData`
      = help: if you intended `T` to be a const parameter, use `const T: usize` instead

    ---- src/internals/check.rs - internals::check::check_remote_generic (line 29) stdout ----
    error: unknown start of token: \u{2026}
     --> src/internals/check.rs:31:21
      |
    4 | struct ConcreteDef {…}
      |                     ^

    error: cannot find attribute `serde` in this scope
     --> src/internals/check.rs:30:3
      |
    3 | #[serde(remote = "Generic<T>")]
      |   ^^^^^
      |
      = note: `serde` is in scope, but it is a crate, not an attribute
    @dtolnay
    dtolnay committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    dc200a6 View commit details
    Browse the repository at this point in the history

  5. Release 1.0.158

    @dtolnay
    dtolnay committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    e305810 View commit details
    Browse the repository at this point in the history
Loading