Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serde-rs/serde
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.128
Choose a base ref
...
head repository: serde-rs/serde
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.130
Choose a head ref
  • 16 commits
  • 15 files changed
  • 2 contributors

Commits on Jun 12, 2021

  1. Configuration menu
    Copy the full SHA
    ca772a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e0fc467 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2021

  1. Configuration menu
    Copy the full SHA
    c1ce03b View commit details
    Browse the repository at this point in the history
  2. Format PR 1992 with rustfmt

    dtolnay committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    9451ea8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    75d8902 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2077 from dtolnay/tryfold

    Use try_fold in default implementation of collect_seq, collect_map
    dtolnay authored Aug 21, 2021
    Configuration menu
    Copy the full SHA
    55fdbea View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Add test of remote with a packed struct

    Currently fails to build:
    
        error: reference to packed field is unaligned
           --> test_suite/tests/test_gen.rs:858:10
            |
        858 | #[derive(Serialize, Deserialize)]
            |          ^^^^^^^^^
            |
        note: the lint level is defined here
           --> test_suite/tests/test_gen.rs:5:9
            |
        5   | #![deny(warnings)]
            |         ^^^^^^^^
            = note: `#[deny(unaligned_references)]` implied by `#[deny(warnings)]`
            = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
            = note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
            = note: this error originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info)
    
        error: reference to packed field is unaligned
           --> test_suite/tests/test_gen.rs:858:21
            |
        858 | #[derive(Serialize, Deserialize)]
            |                     ^^^^^^^^^^^
            |
            = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
            = note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
            = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)
    dtolnay committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    14accf7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    54102ee View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2079 from dtolnay/packedremote

    Fix unaligned reference warnings on packed remote def
    dtolnay authored Aug 23, 2021
    Configuration menu
    Copy the full SHA
    dc0c0dc View commit details
    Browse the repository at this point in the history
  4. Add test of packed struct that cannot be destructured

    Currently fails:
    
        error[E0509]: cannot move out of type `RemotePackedNonCopyDef`, which implements the `Drop` trait
           --> test_suite/tests/test_gen.rs:876:10
            |
        876 | #[derive(Deserialize)]
            |          ^^^^^^^^^^^
            |          |
            |          cannot move out of here
            |          data moved here
            |          move occurs because `__v1` has type `std::string::String`, which does not implement the `Copy` trait
            |
            = note: this error originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info)
    dtolnay committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    714c8a5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4a66c5f View commit details
    Browse the repository at this point in the history
  6. Merge pull request #2080 from dtolnay/packeddrop

    Support packed remote struct without destructuring
    dtolnay authored Aug 23, 2021
    Configuration menu
    Copy the full SHA
    c1c0ede View commit details
    Browse the repository at this point in the history
  7. Release 1.0.129

    dtolnay committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    2b92c80 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2021

  1. Configuration menu
    Copy the full SHA
    3f120fb View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2081 from dtolnay/accessunsized

    Enable unsized Map/SeqAccess types to use the impl for &mut
    dtolnay authored Aug 28, 2021
    Configuration menu
    Copy the full SHA
    87d41b5 View commit details
    Browse the repository at this point in the history
  3. Release 1.0.130

    dtolnay committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    65e1a50 View commit details
    Browse the repository at this point in the history
Loading