Merge pull request #2950 from aytey/fix_lifetime_issue_2024

dtolnay · web-flow · commit bb58726133fb · 2025-09-14T11:08:16.000-07:00
Fix temporary value lifetime in `serialize_struct`
diff --git a/serde_derive/src/ser.rs b/serde_derive/src/ser.rs
@@ -1235,7 +1235,7 @@ fn wrap_serialize_with(
         #serialize_with(#(#self_var.values.#field_access, )* #serializer_var)
     };
 
-    quote!({
+    quote!(&{
         #[doc(hidden)]
         struct __SerializeWith #wrapper_impl_generics #where_clause {
             values: (#(&'__a #field_tys, )*),
@@ -1252,7 +1252,7 @@ fn wrap_serialize_with(
             }
         }
 
-        &__SerializeWith {
+        __SerializeWith {
             values: (#(#field_exprs, )*),
             phantom: _serde::__private::PhantomData::<#this_type #ty_generics>,
         }

Original file line number	Diff line number	Diff line change
`@@ -1235,7 +1235,7 @@ fn wrap_serialize_with(`
`1235`	`1235`	`#serialize_with(#(#self_var.values.#field_access, )* #serializer_var)`
`1236`	`1236`	`};`
`1237`	`1237`
`1238`		`- quote!({`
	`1238`	`+ quote!(&{`
`1239`	`1239`	`#[doc(hidden)]`
`1240`	`1240`	`struct __SerializeWith #wrapper_impl_generics #where_clause {`
`1241`	`1241`	`values: (#(&'__a #field_tys, )*),`
`@@ -1252,7 +1252,7 @@ fn wrap_serialize_with(`
`1252`	`1252`	`}`
`1253`	`1253`	`}`
`1254`	`1254`
`1255`		`- &__SerializeWith {`
	`1255`	`+ __SerializeWith {`
`1256`	`1256`	`values: (#(#field_exprs, )*),`
`1257`	`1257`	`phantom: _serde::__private::PhantomData::<#this_type #ty_generics>,`
`1258`	`1258`	`}`