Skip to content

Add missing attribute documentation #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2019
Merged

Conversation

tobz1000
Copy link
Contributor

@tobz1000 tobz1000 commented May 4, 2019

Added docs for missing Container attributes. These were mostly done by inspecting serde_derive source; not by testing the functionality. Hopefully the descriptions are accurate.

Added docs for attributes which can specify different options for Serialize and Deserialize (fixes #77). I've also grouped these different variants of each attribute together, although I'm not sure how gitbook will render them. Let me know if this styling/grouping could be improved.

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit a75187f into serde-rs:master May 4, 2019
@dtolnay
Copy link
Member

dtolnay commented May 4, 2019

I took the field_identifier and variant_identifier sections back out because as the explanations even say, those attributes are probably not useful for the purposes that a reader would probably be on this page. They would be better explained on a page about handwriting Deserialize impls for a struct or enum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Document rename(serialize = "...", deserialize = "...")
2 participants