-
Notifications
You must be signed in to change notification settings - Fork 565
Comparing changes
Open a pull request
base repository: serde-rs/json
base: v1.0.74
head repository: serde-rs/json
compare: v1.0.78
- 19 commits
- 11 files changed
- 1 contributor
Commits on Jan 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c79d9ad - Browse repository at this point
Copy the full SHA c79d9adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f45930 - Browse repository at this point
Copy the full SHA 3f45930View commit details
Commits on Jan 8, 2022
-
Raise toolchain version for preserve_order to rust 1.46
Our indexmap dependency needs at least this version. error[E0658]: use of unstable library feature 'vec_drain_as_slice': recently added --> github.com-1ecc6299db9ec823/indexmap-1.8.0/src/map.rs:1182:30 | 1182 | let iter = self.iter.as_slice().iter().map(Bucket::refs); | ^^^^^^^^ error[E0658]: use of unstable library feature 'vec_drain_as_slice': recently added --> github.com-1ecc6299db9ec823/indexmap-1.8.0/src/set.rs:842:30 | 842 | let iter = self.iter.as_slice().iter().map(Bucket::key_ref); | ^^^^^^^^
Configuration menu - View commit details
-
Copy full SHA for aebe84c - Browse repository at this point
Copy the full SHA aebe84cView commit details
Commits on Jan 15, 2022
-
Disable buggy iter_not_returning_iterator lint
rust-lang/rust-clippy#8285 error: this method is named `iter` but its return type does not implement `Iterator` --> src/map.rs:238:5 | 238 | pub fn iter(&self) -> Iter { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D clippy::iter-not-returning-iterator` implied by `-D clippy::pedantic` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_not_returning_iterator error: this method is named `iter_mut` but its return type does not implement `Iterator` --> src/map.rs:246:5 | 246 | pub fn iter_mut(&mut self) -> IterMut { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_not_returning_iterator
Configuration menu - View commit details
-
Copy full SHA for 6691977 - Browse repository at this point
Copy the full SHA 6691977View commit details
Commits on Jan 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0ca5a69 - Browse repository at this point
Copy the full SHA 0ca5a69View commit details -
Configuration menu - View commit details
-
Copy full SHA for d541381 - Browse repository at this point
Copy the full SHA d541381View commit details -
Merge pull request #848 from serde-rs/num
Deserialize small numbers as integers in arbitrary_precision
Configuration menu - View commit details
-
Copy full SHA for 36c43bf - Browse repository at this point
Copy the full SHA 36c43bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for a22b686 - Browse repository at this point
Copy the full SHA a22b686View commit details
Commits on Jan 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8ecd483 - Browse repository at this point
Copy the full SHA 8ecd483View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19e9b74 - Browse repository at this point
Copy the full SHA 19e9b74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71257c5 - Browse repository at this point
Copy the full SHA 71257c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c15649 - Browse repository at this point
Copy the full SHA 4c15649View commit details -
Improve error on compiling with neither std nor alloc
Before: error: expected item, found `"serde_json requires that either `std` (default) or `alloc` feature is enabled"` --> src/features_check/error.rs:1:1 | 1 | "serde_json requires that either `std` (default) or `alloc` feature is enabled" | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected item error[E0407]: method `visit_string` is not a member of trait `Visitor` --> src/raw.rs:455:5 | 455 | fn visit_string<E>(self, s: String) -> Result<Self::Value, E> | ^ ------------ help: there is an associated function with a similar name: `visit_str` | _____| | | 456 | | where 457 | | E: de::Error, 458 | | { 459 | | Ok(RawValue::from_owned(s.into_boxed_str())) 460 | | } | |_____^ not a member of trait `Visitor` error[E0046]: not all trait items implemented, missing: `collect_str` --> src/ser.rs:1376:1 | 1376 | impl<'a, W: io::Write, F: Formatter> ser::Serializer for RawValueStrEmitter<'a, W, F> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `collect_str` in implementation | = help: implement the missing item: `fn collect_str<T>(self, _: &T) -> core::result::Result<<Self as serde::Serializer>::Ok, <Self as serde::Serializer>::Error> where T: Display { todo!() }` error[E0046]: not all trait items implemented, missing: `collect_str` --> src/value/ser.rs:864:1 | 864 | impl serde::ser::Serializer for RawValueEmitter { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `collect_str` in implementation | = help: implement the missing item: `fn collect_str<T>(self, _: &T) -> core::result::Result<<Self as serde::Serializer>::Ok, <Self as serde::Serializer>::Error> where T: Display { todo!() }` error[E0599]: no method named `visit_string` found for struct `BoxedFromString` in the current scope --> src/raw.rs:452:14 | 428 | pub struct BoxedFromString; | --------------------------- method `visit_string` not found for this ... 452 | self.visit_string(s.to_owned()) | ^^^^^^^^^^^^ method not found in `BoxedFromString` After: error: expected item, found `"serde_json requires that either `std` (default) or `alloc` feature is enabled"` --> src/features_check/error.rs:1:1 | 1 | "serde_json requires that either `std` (default) or `alloc` feature is enabled" | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected item
Configuration menu - View commit details
-
Copy full SHA for 5fe9bdd - Browse repository at this point
Copy the full SHA 5fe9bddView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8512af - Browse repository at this point
Copy the full SHA d8512afView commit details -
Add test of deserializing a &RawValue in map key position
Currently fails with: ---- test_raw_value_in_map_key stdout ---- thread 'test_borrowed_raw_value' panicked at 'called `Result::unwrap()` on an `Err` value: Error("invalid type: newtype struct, expected any valid JSON value", line: 1, column: 2)', tests/test.rs:2230:52
Configuration menu - View commit details
-
Copy full SHA for 6a3fb68 - Browse repository at this point
Copy the full SHA 6a3fb68View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5cdfcc - Browse repository at this point
Copy the full SHA e5cdfccView commit details -
Merge pull request #851 from serde-rs/rawkey
Support deserializing map key as &RawValue
Configuration menu - View commit details
-
Copy full SHA for cbb0342 - Browse repository at this point
Copy the full SHA cbb0342View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d81cbd - Browse repository at this point
Copy the full SHA 2d81cbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98cafac - Browse repository at this point
Copy the full SHA 98cafacView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.74...v1.0.78