Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serde-rs/json
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.74
Choose a base ref
...
head repository: serde-rs/json
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.78
Choose a head ref
  • 19 commits
  • 11 files changed
  • 1 contributor

Commits on Jan 3, 2022

  1. Configuration menu
    Copy the full SHA
    c79d9ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f45930 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2022

  1. Raise toolchain version for preserve_order to rust 1.46

    Our indexmap dependency needs at least this version.
    
        error[E0658]: use of unstable library feature 'vec_drain_as_slice': recently added
            --> github.com-1ecc6299db9ec823/indexmap-1.8.0/src/map.rs:1182:30
             |
        1182 |         let iter = self.iter.as_slice().iter().map(Bucket::refs);
             |                              ^^^^^^^^
    
        error[E0658]: use of unstable library feature 'vec_drain_as_slice': recently added
           --> github.com-1ecc6299db9ec823/indexmap-1.8.0/src/set.rs:842:30
            |
        842 |         let iter = self.iter.as_slice().iter().map(Bucket::key_ref);
            |                              ^^^^^^^^
    dtolnay committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    aebe84c View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Disable buggy iter_not_returning_iterator lint

    rust-lang/rust-clippy#8285
    
        error: this method is named `iter` but its return type does not implement `Iterator`
           --> src/map.rs:238:5
            |
        238 |     pub fn iter(&self) -> Iter {
            |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
            |
            = note: `-D clippy::iter-not-returning-iterator` implied by `-D clippy::pedantic`
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_not_returning_iterator
    
        error: this method is named `iter_mut` but its return type does not implement `Iterator`
           --> src/map.rs:246:5
            |
        246 |     pub fn iter_mut(&mut self) -> IterMut {
            |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_not_returning_iterator
    dtolnay committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    6691977 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2022

  1. Configuration menu
    Copy the full SHA
    0ca5a69 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d541381 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #848 from serde-rs/num

    Deserialize small numbers as integers in arbitrary_precision
    dtolnay authored Jan 16, 2022
    Configuration menu
    Copy the full SHA
    36c43bf View commit details
    Browse the repository at this point in the history
  4. Release 1.0.75

    dtolnay committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    a22b686 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2022

  1. Configuration menu
    Copy the full SHA
    8ecd483 View commit details
    Browse the repository at this point in the history
  2. Release 1.0.76

    dtolnay committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    19e9b74 View commit details
    Browse the repository at this point in the history
  3. Add discord invite links

    dtolnay committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    71257c5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4c15649 View commit details
    Browse the repository at this point in the history
  5. Improve error on compiling with neither std nor alloc

    Before:
    
        error: expected item, found `"serde_json requires that either `std` (default) or `alloc` feature is enabled"`
         --> src/features_check/error.rs:1:1
          |
        1 | "serde_json requires that either `std` (default) or `alloc` feature is enabled"
          | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected item
    
        error[E0407]: method `visit_string` is not a member of trait `Visitor`
           --> src/raw.rs:455:5
            |
        455 |       fn visit_string<E>(self, s: String) -> Result<Self::Value, E>
            |       ^  ------------ help: there is an associated function with a similar name: `visit_str`
            |  _____|
            | |
        456 | |     where
        457 | |         E: de::Error,
        458 | |     {
        459 | |         Ok(RawValue::from_owned(s.into_boxed_str()))
        460 | |     }
            | |_____^ not a member of trait `Visitor`
    
        error[E0046]: not all trait items implemented, missing: `collect_str`
            --> src/ser.rs:1376:1
             |
        1376 | impl<'a, W: io::Write, F: Formatter> ser::Serializer for RawValueStrEmitter<'a, W, F> {
             | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `collect_str` in implementation
             |
             = help: implement the missing item: `fn collect_str<T>(self, _: &T) -> core::result::Result<<Self as serde::Serializer>::Ok, <Self as serde::Serializer>::Error> where T: Display { todo!() }`
    
        error[E0046]: not all trait items implemented, missing: `collect_str`
           --> src/value/ser.rs:864:1
            |
        864 | impl serde::ser::Serializer for RawValueEmitter {
            | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `collect_str` in implementation
            |
            = help: implement the missing item: `fn collect_str<T>(self, _: &T) -> core::result::Result<<Self as serde::Serializer>::Ok, <Self as serde::Serializer>::Error> where T: Display { todo!() }`
    
        error[E0599]: no method named `visit_string` found for struct `BoxedFromString` in the current scope
           --> src/raw.rs:452:14
            |
        428 | pub struct BoxedFromString;
            | --------------------------- method `visit_string` not found for this
        ...
        452 |         self.visit_string(s.to_owned())
            |              ^^^^^^^^^^^^ method not found in `BoxedFromString`
    
    After:
    
        error: expected item, found `"serde_json requires that either `std` (default) or `alloc` feature is enabled"`
         --> src/features_check/error.rs:1:1
          |
        1 | "serde_json requires that either `std` (default) or `alloc` feature is enabled"
          | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected item
    dtolnay committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    5fe9bdd View commit details
    Browse the repository at this point in the history
  6. Release 1.0.77

    dtolnay committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    d8512af View commit details
    Browse the repository at this point in the history
  7. Add test of deserializing a &RawValue in map key position

    Currently fails with:
    
        ---- test_raw_value_in_map_key stdout ----
        thread 'test_borrowed_raw_value' panicked at 'called `Result::unwrap()`
        on an `Err` value: Error("invalid type: newtype struct, expected any
        valid JSON value", line: 1, column: 2)', tests/test.rs:2230:52
    dtolnay committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    6a3fb68 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e5cdfcc View commit details
    Browse the repository at this point in the history
  9. Merge pull request #851 from serde-rs/rawkey

    Support deserializing map key as &RawValue
    dtolnay authored Jan 22, 2022
    Configuration menu
    Copy the full SHA
    cbb0342 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2d81cbd View commit details
    Browse the repository at this point in the history
  11. Release 1.0.78

    dtolnay committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    98cafac View commit details
    Browse the repository at this point in the history
Loading