Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pod's namespace instead of default #15

Closed
okgolove opened this issue Jun 12, 2020 · 1 comment
Closed

Use pod's namespace instead of default #15

okgolove opened this issue Jun 12, 2020 · 1 comment

Comments

@okgolove
Copy link

Hello!
Thanks for the library, it's really very helpful!

I'd like to ask about using default namespace in case of we do not set namespace in url string, for example:

kubernetes:///test:8090

In this case default namespace will be used to get endpoints.

Is there a reason to use default namespace? Shouldn't we get pod's namespase from file /var/run/secrets/kubernetes.io/serviceaccount/namespace?

@sercand sercand closed this as completed in b37001e Aug 1, 2020
@sercand
Copy link
Owner

sercand commented Aug 1, 2020

@okgolove released v3.0.0 to address this issue. Since it changes existing behavior, bumped the version number to 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants