Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyyaml to 6.0.1 to fix cython build problems #406

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

robert-bo-davis
Copy link
Contributor

This bumps pyyaml to 6.0.1 to resolve build issues related to cython 3.0 release.

See:
yaml/pyyaml#601
yaml/pyyaml#702

Copy link
Owner

@seperman seperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seperman
Copy link
Owner

seperman commented Aug 5, 2023

Thanks for the PR @robert-bo-davis

@codecov-commenter
Copy link

Codecov Report

Merging #406 (1fc9a3a) into dev (a95defa) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev     #406   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          14       14           
  Lines        3257     3257           
=======================================
  Hits         3215     3215           
  Misses         42       42           

@seperman seperman merged commit 38937b1 into seperman:dev Aug 5, 2023
@seperman seperman mentioned this pull request Aug 5, 2023
4 tasks
@seperman
Copy link
Owner

seperman commented Sep 1, 2023

@robert-bo-davis Thanks for contributing.
DeepDiff 6.4.0 is released and includes your work:
https://zepworks.com/deepdiff/current/

huddlej added a commit to blab/popcast that referenced this pull request Sep 3, 2024
Pins deepdiff to the penultimate version (7) which fixes a PyYAML
dependency issue with Cython [1] but which does not have the redesigned
output interface from version 8. This commit should fix CI for Python
versions 3.10 and 3.11.

[1] seperman/deepdiff#406
huddlej added a commit to blab/popcast that referenced this pull request Sep 4, 2024
Pins deepdiff to the latest version (8) which includes a fix a PyYAML
dependency issue with Cython [1]. Also, replaces the deep diff CLI
command in a functional test with a custom Python script that uses the
DeepDiff class, working around an issue where the deep diff CLI did not
properly recognize numeric values and caused the functional test to fail
spuriously. This commit should fix CI for Python versions 3.10 and 3.11.

[1] seperman/deepdiff#406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants