Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JavaDoc comments (and thrown exceptions) for reevaluate functions #76

Open
barrycaceres opened this issue Apr 18, 2024 · 1 comment
Assignees
Labels
java Pull requests that update Java code V4 To be delivered in V4

Comments

@barrycaceres
Copy link
Contributor

Currently the reevaluateRecord() and reevaluateEntity() when Jira GDEV-3790 gets resolved.

Currently the behavior between the two when a record or entity is not found is inconsistent and they both should do the same thing when a "not found" condition occurs. When that happens the Javadoc needs to be updated and possibly the throws clause on the functions with documentation indicating why a SzNotFoundException is thrown (assuming the choice is made to throw an exception).

@barrycaceres barrycaceres self-assigned this Apr 18, 2024
@github-actions github-actions bot added the triage Need to triage label Apr 18, 2024
@barrycaceres barrycaceres added java Pull requests that update Java code V4 To be delivered in V4 and removed triage Need to triage labels Apr 18, 2024
@docktermj
Copy link
Contributor

Looks like GDEV-3790 has been canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code V4 To be delivered in V4
Projects
None yet
Development

No branches or pull requests

2 participants