Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import the crate rolling_file #107

Open
Forsworns opened this issue Feb 27, 2023 · 1 comment
Open

Import the crate rolling_file #107

Forsworns opened this issue Feb 27, 2023 · 1 comment
Labels
area/logging Issue related to logging of Sentinel good first issue Good for newcomers

Comments

@Forsworns
Copy link
Member

Currently, Sentinel implements rolling-file loggers itself. Consider replacing it to the crate rolling_file. We should split these non-core features to reduce the complexity of codebase.

refer to:
@Forsworns Forsworns added good first issue Good for newcomers area/logging Issue related to logging of Sentinel labels Feb 27, 2023
@Forsworns
Copy link
Member Author

may remove log4rs env_logger::Target::Pipe with the rolling-file crate above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/logging Issue related to logging of Sentinel good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Forsworns